Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Andre McCurdy <armccurdy@gmail.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 8/8] rpm: move ASNEEDED over-ride into the rpm	recipe
Date: Fri, 4 May 2018 23:23:39 +0000	[thread overview]
Message-ID: <8ba5b8b622744aa783b1963437fc1cce@XBOX02.axis.com> (raw)
In-Reply-To: <1525474370-7913-8-git-send-email-armccurdy@gmail.com>

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Andre McCurdy
> Sent: den 5 maj 2018 00:53
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 8/8] rpm: move ASNEEDED over-ride into the
> rpm recipe
> 
> Move the recipe specific over-ride for ASNEEDED into the recipe to
> make it more apparent that the over-ride is being applied (and that
> it should be re-checked on version updates, etc).
> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/recipes-devtools/rpm/rpm_4.14.1.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-devtools/rpm/rpm_4.14.1.bb b/meta/recipes-devtools/rpm/rpm_4.14.1.bb
> index 818d3ef..d49530e 100644
> --- a/meta/recipes-devtools/rpm/rpm_4.14.1.bb
> +++ b/meta/recipes-devtools/rpm/rpm_4.14.1.bb
> @@ -73,6 +73,8 @@ BBCLASSEXTEND = "native nativesdk"
>  PACKAGECONFIG ??= ""
>  PACKAGECONFIG[imaevm] = "--with-imaevm,,ima-evm-utils"
> 
> +ASNEEDED = ""
> +
>  # Direct rpm-native to read configuration from our sysroot, not the one it was compiled in
>  # libmagic also has sysroot path contamination, so override it
>  do_install_append_class-native() {
> --
> 1.9.1

This patch does not remove ASNEEDED_pn-rpm = "" from the 
meta/conf/distro/include/as-needed.inc file.

Also, shouldn't ASNEEDED_pn-openobex = "" in 
meta/conf/distro/include/as-needed.inc be moved to the recipe 
in meta-oe to complete the patch set?

//Peter



  reply	other threads:[~2018-05-04 23:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 22:52 [PATCH 1/8] tune-corei7.inc: minor comment tweak to align with tune-core2.inc Andre McCurdy
2018-05-04 22:52 ` [PATCH 2/8] babeltrace: move ASNEEDED over-ride into the babeltrace recipe Andre McCurdy
2018-05-04 22:52 ` [PATCH 3/8] console-tools: move ASNEEDED over-ride into the console-tools recipe Andre McCurdy
2018-05-04 22:52 ` [PATCH 4/8] distcc: move ASNEEDED over-ride into the distcc recipe Andre McCurdy
2018-05-04 22:52 ` [PATCH 5/8] icu: move ASNEEDED over-ride into icu.inc Andre McCurdy
2018-05-04 22:52 ` [PATCH 6/8] pciutils: move ASNEEDED over-ride into the pciutils recipe Andre McCurdy
2018-05-04 22:52 ` [PATCH 7/8] puzzles: move ASNEEDED over-ride into the puzzles recipe Andre McCurdy
2018-05-04 22:52 ` [PATCH 8/8] rpm: move ASNEEDED over-ride into the rpm recipe Andre McCurdy
2018-05-04 23:23   ` Peter Kjellerstedt [this message]
2018-05-05  0:52     ` Andre McCurdy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ba5b8b622744aa783b1963437fc1cce@XBOX02.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox