Re: [OE-core][dunfell 09/17] libubootenv: Depend on zlib

["Stefano Babic" <sbabic@denx.de>]

On 26.05.20 10:57, Paul Barker wrote:
> On Tue, 26 May 2020 at 09:56, Adrian Bunk <bunk@stusta.de> wrote:
>>
>> On Tue, May 26, 2020 at 09:24:59AM +0100, Paul Barker wrote:
>>> On Mon, 25 May 2020 at 23:37, Steve Sakoman <steve@sakoman.com> wrote:
>>>>
>>>> From: Marek Vasut <marex@denx.de>
>>>>
>>>> The libubootenv depends on zlib as it calls at least crc32() from
>>>> there and links against it. Add the DEPENDS entry.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Stefano Babic <sbabic@denx.de>
>>>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>>> Signed-off-by: Steve Sakoman <steve@sakoman.com>
>>>> (cherry picked from commit db513f9ec59b7ac526b2cdc42b0eb2573e134bc4)
>>>> Signed-off-by: Steve Sakoman <steve@sakoman.com>
>>>> ---
>>>>  meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
>>>> index 3251d0f05b..fa90a12bf8 100644
>>>> --- a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
>>>> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
>>>> @@ -1,5 +1,5 @@
>>>>  SUMMARY = "U-Boot libraries and tools to access environment"
>>>> -DEPENDS += "mtd-utils"
>>>> +DEPENDS += "mtd-utils zlib"
>>>>
>>>>  DESCRIPTION = "This package contains tools and libraries to read \
>>>>  and modify U-Boot environment. \
>>>> --
>>>> 2.17.1
>>>
>>> Is this actually needed for the u-boot version in dunfell? My
>>> understanding when I saw the original patch was that this is a new
>>> requirement of the latest u-boot.
>>
>> libubootenv (not u-boot) uses zlib also in dunfell,
>> and a direct dependency looks correct to me.
>>
>> I assume the breaking case involves a layer shipping an own mtd-utils
>> recipe that does not pull in zlib.
> 

Yes, it is exactly the case. dunfell builds without issues
libubootenv-bin (fw_setenv / fw_printenv). Users of library have
doscovered the issue because they have not zlib in their own recipe.

> Thanks for the confirmation, I understand now. Looks good for dunfell.
> 

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================