Re: [OE-core] [PATCH 1/6] oeqa runtime ping.py: make run_network_serialdebug() specific to qemu

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2025-06-27 at 09:29 +0300, Mikko Rapeli via lists.openembedded.org wrote:
> Only qemu runner supports self.targets.runner. ssh runner does not
> define this and on error path this function causes another exception.
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
>  meta/lib/oeqa/runtime/cases/ping.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oeqa/runtime/cases/ping.py b/meta/lib/oeqa/runtime/cases/ping.py
> index efb91d4cc9da..515d376602bd 100644
> --- a/meta/lib/oeqa/runtime/cases/ping.py
> +++ b/meta/lib/oeqa/runtime/cases/ping.py
> @@ -10,6 +10,7 @@ from time import sleep
>  from oeqa.runtime.case import OERuntimeTestCase, run_network_serialdebug
>  from oeqa.core.decorator.oetimeout import OETimeout
>  from oeqa.core.exception import OEQATimeoutError
> +from oeqa.core.target.qemu import OEQemuTarget
>  
>  class PingTest(OERuntimeTestCase):
>  
> @@ -36,7 +37,8 @@ class PingTest(OERuntimeTestCase):
>                      count = 0
>                      sleep(1)
>          except OEQATimeoutError:
> -            run_network_serialdebug(self.target.runner)
> +            if isinstance(self.target, OEQemuTarget):
> +                run_network_serialdebug(self.target.runner)
>              self.fail("Ping timeout error for address %s, count %s, output: %s" % (self.target.ip, count, output))
>          msg = ('Expected 5 consecutive, got %d.\n'
>                 'ping output is:\n%s' % (count,output))

Rather than make the tests target runner specific, should we put a
dummy function in the main class, then backends can support this if
they can/want to?

Cheers,

Richard