Re: [OE-core] [PATCH] u-boot: do not pass O=$B, if $B = $S

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2024-07-04 at 21:18 +0200, Jörg Sommer via
lists.openembedded.org wrote:
> From: Jörg Sommer <joerg.sommer@navimatix.de>
> 
> The u-boot Makefile (even v2024.07) doesn't like it, when `O=…` is
> the same
> directory as the source directory and complains about a dirty source
> directory; see below. This happens when `UBOOT_MACHINE` is set and
> not
> `UBOOT_CONFIG`.
> 
> ```
> % make O=$PWD all
> make[1]: Entering directory '/home/joerg/git/u-boot'
>   UPD     include/generated/timestamp_autogenerated.h
>   Using /home/joerg/git/u-boot as source for U-Boot
>   /home/joerg/git/u-boot is not clean, please run 'make mrproper'
>   in the '/home/joerg/git/u-boot' directory.
> make[1]: *** [/home/joerg/git/u-boot/Makefile:1928: prepare3] Error 1
> make[1]: Leaving directory '/home/joerg/git/u-boot'
> make: *** [Makefile:177: sub-make] Error 2
> ```
> 
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> ---
>  meta/recipes-bsp/u-boot/u-boot.inc | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Can we not just always ensure B is set to somewhere different to S?

Building in S is generally a bad idea and we try to avoid that with
anything that supports it.

Cheers,

Richard