public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Ross Burton <Ross.Burton@arm.com>
To: Marta Rybczynska <marta.rybczynska@ygreky.com>
Cc: "rybczynska@gmail.com" <rybczynska@gmail.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2][OE-core 4/4] cve-check: allow feed choice
Date: Wed, 15 Jan 2025 12:23:15 +0000	[thread overview]
Message-ID: <90F815DC-7009-4529-91DC-93F33737DEC4@arm.com> (raw)
In-Reply-To: <6703A7E3-30BD-44E9-875C-058BD2EAF58C@arm.com>

Hi,

Also I ran the scanner against core-image-sato for each of the feeds and interestingly nvd2 was the only one to report CVE-1999-0524.  Do you have any idea why this might be?

That said, a fetch taking a minute or so instead of almost an hour is a great improvement!

Cheers,
Ross

> On 14 Jan 2025, at 17:54, Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote:
> 
> On 24 Dec 2024, at 10:25, Marta Rybczynska via lists.openembedded.org <rybczynska=gmail.com@lists.openembedded.org> wrote:
> 
> There’s an inconsistency:
> 
>> Set the NVD_DB_VERSION variable to choose feed:
>> NVD2 (default) - the NVD feed with API version 2
>> NVD1 - the NVD JSON feed (deprecated)
>> FKIE - the FKIE-CAD feed reconstruction
> 
> “NVD1”
> 
>> +# Possible database sources: NVD1, NVD2, FKIE
>> +NVD_DB_VERSION ?= "NVD2"
> 
> “NVD1”
> 
>> +    if nvd_database_type not in ("NVD", "NVD2", "FKIE”):
> 
> “NVD”
> 
> I’m thinking “NVD1” should be used everywhere.
> 
> If you set it as the documentation says then every recipe throws a warning, which is quite the pastebomb.  Might be better to make it bb.fatal() and tell the user to fix their typo?
> 
> Ross
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#209811): https://lists.openembedded.org/g/openembedded-core/message/209811
> Mute This Topic: https://lists.openembedded.org/mt/110270325/6875888
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


  reply	other threads:[~2025-01-15 12:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-24 10:25 [PATCH v2][OE-core 0/4] Allow choosing the NVD feed Marta Rybczynska
2024-12-24 10:25 ` [PATCH v2][OE-core 1/4] cve-update-db-native: restore Marta Rybczynska
2024-12-24 10:25 ` [PATCH v2][OE-core 2/4] cve-update-db-native: update structure Marta Rybczynska
2024-12-24 10:25 ` [PATCH v2][OE-core 3/4] cve-update-db-native: add the fkie source Marta Rybczynska
2024-12-24 10:25 ` [PATCH v2][OE-core 4/4] cve-check: allow feed choice Marta Rybczynska
2025-01-14 17:54   ` [OE-core] " Ross Burton
2025-01-15 12:23     ` Ross Burton [this message]
2025-02-05 12:03       ` Marta Rybczynska
2025-02-05 14:38     ` Marta Rybczynska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90F815DC-7009-4529-91DC-93F33737DEC4@arm.com \
    --to=ross.burton@arm.com \
    --cc=marta.rybczynska@ygreky.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rybczynska@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox