Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Vyacheslav Yurkov <uvv.mail@gmail.com>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"steve@sakoman.com" <steve@sakoman.com>
Cc: "openembedded-devel@lists.openembedded.org"
	<openembedded-devel@lists.openembedded.org>
Subject: Re: [OE-core] nanbield: grpc_1.56.2 fails nativesdk build
Date: Tue, 13 Feb 2024 19:40:56 +0100	[thread overview]
Message-ID: <90a1eab2-8deb-4f6a-8f0d-e6fc910c10d7@gmail.com> (raw)
In-Reply-To: <ade3562aea69ab37a64d0bdf82a8bd95e97a3679.camel@infinera.com>

[-- Attachment #1: Type: text/plain, Size: 2167 bytes --]

On 13.02.2024 16:19, Joakim Tjernlund wrote:
> Tested and works too, but I see this patch was reverted:
>
>
> Revert "protobuf: stage protoc binary to sysroot"
>
>      This reverts commit a0557fe5433620717eeb00d3b16801711337b1a4.
>
>      As said by Ross[Ø]:
>      "Putting the _target_ protoc into the sysroot for executation at _build_
>      time isn't useful because even if it has the right architecture, the
>      tune might be incompatible.  Recipes which want protoc should just depend
>      on protobuf-native."
>
>      This has been reverted recently by Samuli[1]:
>      "If protoc is enabled for the build, recipes using protobuf will
>      fail when protoc is not available in the recipe sysroot"
>
>      Be the revert is incorret as This is an issue coming from qtgrpc
>      other recipes that use protobuf or gRPC compiler, proplery looks for
>      the binary in the correct sysroot folder.
>
>      Qtgrpc recipe should fix this issue at the recipe level, for example this
>      is what I've done for "etcd-cpp-apiv3" recipe[2] that doesn't need this
>      patch to properly compile.
>
>      So keeping this hack doesn't seems to be a correct fix.
>
>      Note that qtgrpc recipe isn't available on meta-oe nor any other public
>      layers.
>
>      0:https://patchwork.yoctoproject.org/project/oe/patch/20230904161230.377450-1-ross.burton@arm.com/
>      1:https://patchwork.yoctoproject.org/project/oe/patch/20230927051101.3088498-1-samuli.piippo@qt.io/
>      2:https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/commit/47f0d9e0326f3cc31c801a0ecf7312d1049ece3e
>
>      CC: Samuli Piippo<samuli.piippo@gmail.com>
>      CC: Ross Burton<ross.burton@arm.com>
>      Signed-off-by: Clément Péron<peron.clem@gmail.com>
>      Signed-off-by: Khem Raj<raj.khem@gmail.com>
>      (cherry picked from commit bfb626a23022d871ce3c0c64cb9e5d1cc17c737e)
>      Signed-off-by: Armin Kuster<akuster808@gmail.com>
>
> So then what is the correct fix for grpc ?
>
>   Joakim
>

Reverted and then applied again :)

If you are interested, see the full discussion here 
https://lists.openembedded.org/g/openembedded-devel/topic/101679410#105284

Slava

[-- Attachment #2: Type: text/html, Size: 3464 bytes --]

  reply	other threads:[~2024-02-13 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <17B23A54B6BB5F11.15017@lists.openembedded.org>
2024-02-13 14:08 ` [OE-core] nanbield: grpc_1.56.2 fails nativesdk build Joakim Tjernlund
2024-02-13 14:14   ` Vyacheslav Yurkov
2024-02-13 14:45     ` Joakim Tjernlund
2024-02-13 15:19       ` Joakim Tjernlund
2024-02-13 18:40         ` Vyacheslav Yurkov [this message]
2024-02-14  9:42           ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90a1eab2-8deb-4f6a-8f0d-e6fc910c10d7@gmail.com \
    --to=uvv.mail@gmail.com \
    --cc=Joakim.Tjernlund@infinera.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox