Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Hong Liu <hongl.fnst@cn.fujitsu.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] btrfs-tools: Update to 4.16
Date: Thu, 3 May 2018 12:32:04 +0300	[thread overview]
Message-ID: <928b0405-b383-cd27-571e-8fc72b41d6b7@linux.intel.com> (raw)
In-Reply-To: <20180503090918.20964-2-hongl.fnst@cn.fujitsu.com>

On 05/03/2018 12:09 PM, Hong Liu wrote:
> -DEPENDS = "util-linux attr e2fsprogs lzo acl"
> +DEPENDS = "util-linux attr e2fsprogs lzo acl python3"
> +EXTRA_OECONF = "--disable-zstd --disable-python"
> +INSANE_SKIP_${PN} = "ldflags"

You need to explain all of these changes in the commit message. 
Particularly the combination of adding a python dependency and then 
passing --disable-python looks odd.

Alex



  reply	other threads:[~2018-05-03  9:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03  9:09 [PATCH] flex: update to 2.6.4 Hong Liu
2018-05-03  9:09 ` [PATCH] btrfs-tools: Update to 4.16 Hong Liu
2018-05-03  9:32   ` Alexander Kanavin [this message]
2018-05-03  9:33 ` [PATCH] flex: update to 2.6.4 Burton, Ross
2018-05-03  9:35 ` ✗ patchtest: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=928b0405-b383-cd27-571e-8fc72b41d6b7@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=hongl.fnst@cn.fujitsu.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox