Re: [OE-core][dunfell 6/6] scripts/contrib/oe-build-perf-report-email.py: remove obsolete check for phantomjs and optipng

Steve Sakoman
2022-04-28T21:50:41Z

This patch is in master-next, but not yet master. I decided to run
the dunfell review process in parallel with master. I will wait till
the patch hits master before sending a pull request (and will add the
cherry-pick notation)

Steve

On Thu, Apr 28, 2022 at 11:47 AM Steve Sakoman via
lists.openembedded.org <steve=sakoman.com@lists.openembedded.org>
wrote:
>
> Use of those tools was removed in b5c131006e3fad0a15e6cdf81f71dc1e96647028
> perf-build-test/report: Drop phantomjs and html email reports support
>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
> scripts/contrib/oe-build-perf-report-email.py | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/scripts/contrib/oe-build-perf-report-email.py b/scripts/contrib/oe-build-perf-report-email.py
> index c900720f6e..7192113c28 100755
> --- a/scripts/contrib/oe-build-perf-report-email.py
> +++ b/scripts/contrib/oe-build-perf-report-email.py
> @@ -27,17 +27,6 @@ logging.basicConfig(level=logging.INFO, format="%(levelname)s: %(message)s")
> log = logging.getLogger('oe-build-perf-report')
>
>
> -def check_utils():
> - """Check that all needed utils are installed in the system"""
> - missing = []
> - for cmd in ('phantomjs', 'optipng'):
> - if not shutil.which(cmd):
> - missing.append(cmd)
> - if missing:
> - log.error("The following tools are missing: %s", ' '.join(missing))
> - sys.exit(1)
> -
> -
> def parse_args(argv):
> """Parse command line arguments"""
> description = """Email build perf test report"""
> @@ -101,8 +90,6 @@ def main(argv=None):
> if args.debug:
> log.setLevel(logging.DEBUG)
>
> - check_utils()
> -
> if args.outdir:
> outdir = args.outdir
> if not os.path.exists(outdir):
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#164984): https://lists.openembedded.org/g/openembedded-core/message/164984
> Mute This Topic: https://lists.openembedded.org/mt/90764072/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>