Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Max Krummenacher" <max.oss.09@gmail.com>
To: Steve Sakoman <steve@sakoman.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][dunfell 08/15] kernel.bbclass: make dependency on lzop-native conditional
Date: Mon, 13 Jul 2020 23:29:56 +0200	[thread overview]
Message-ID: <92cf9c7e6eaec95059019b461becd588b2b93dbf.camel@gmail.com> (raw)
In-Reply-To: <ad44aab08c0c204923d44aa37c39559a7bd843c0.1594649587.git.steve@sakoman.com>

Hi

Can we drop this one from the backports?

The patch possibly reduces a bit of build time if lzop-native is not used
by any other recipe, but does not fix anything.

One can build a zImage which is compressed with lzo. For a kernel recipe which
does use a zImage with lzo and relies on the kernel.bbclass to add a depend on
lzop-native the build breaks.

Cheers
Max

Am Montag, den 13.07.2020, 04:16 -1000 schrieb Steve Sakoman:
> From: Timon Ulrich <t.ulrich@anapur.de>
> 
> a native lzop is only needed when an lzo compressed initramfs is actually present
> 
> Signed-off-by: Timon Ulrich <t.ulrich@anapur.de>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd)
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/classes/kernel.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 9e3c34ad48..af7e88b380 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -4,7 +4,8 @@ KERNEL_PACKAGE_NAME ??= "kernel"
>  KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else
> d.getVar("KERNEL_PACKAGE_NAME") }"
>  
>  PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
> -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native
> lzop-native bison-native"
> +DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native
> bison-native"
> +DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", "", d)}"
>  DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", "lz4-native", "", d)}"
>  PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
>  
> 


  reply	other threads:[~2020-07-13 21:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 14:16 [OE-core][dunfell 00/15] Patch review Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 01/15] gobject-introspection: add a patch to fix a build race Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 02/15] icu: make filtered data generation optional, serial and off by default Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 03/15] classes/archiver: run do_unpack_and_patch after do_preconfigure Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 04/15] classes/archive: do_configure should not depend on do_ar_patched Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 05/15] kernel/yocto: ensure that defconfigs are processed first Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 06/15] kernel/yocto: fix search for defconfig from src_uri Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 07/15] kernel.bbclass: add lz4 dependency and fix the call to lz4 Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 08/15] kernel.bbclass: make dependency on lzop-native conditional Steve Sakoman
2020-07-13 21:29   ` Max Krummenacher [this message]
2020-07-13 22:52     ` Andre McCurdy
2020-07-13 23:04     ` Steve Sakoman
2020-07-13 23:59     ` Khem Raj
2020-07-14 12:42       ` Max Krummenacher
2020-07-13 14:16 ` [OE-core][dunfell 09/15] systemd: remove kernel-install from base pkg Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 10/15] oeqa/core/loader: fix regex to include numbers Steve Sakoman
2020-07-13 14:16 ` [OE-core][dunfell 11/15] linux-yocto/5.4: update to v5.4.50 Steve Sakoman
2020-07-13 14:17 ` [OE-core][dunfell 12/15] openssl: move ${libdir}/[...]/openssl.cnf to ${PN}-conf Steve Sakoman
2020-07-13 14:17 ` [OE-core][dunfell 13/15] devtool: default to empty string, if LIC_FILES_CHKSUM is not available Steve Sakoman
2020-07-13 14:17 ` [OE-core][dunfell 14/15] libnl: Extend for native/nativesdk Steve Sakoman
2020-07-13 14:17 ` [OE-core][dunfell 15/15] coreutils: don't split stdbuf to own package with single-binary Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92cf9c7e6eaec95059019b461becd588b2b93dbf.camel@gmail.com \
    --to=max.oss.09@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox