Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core] [PATCH] mirrors: Add uninative mirror on kernel.org
Date: Wed, 10 Nov 2021 20:44:57 +0000	[thread overview]
Message-ID: <93b2df22824c47ff9c08365792a805d2@axis.com> (raw)
In-Reply-To: <20211109132131.3789773-1-richard.purdie@linuxfoundation.org>

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 9 november 2021 14:22
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] mirrors: Add uninative mirror on kernel.org
> 
> At the last nas outage, we realised that we don't have good mirrors of the
> uninative tarball if our main system can't be accessed. kernel.org mirrors
> some Yocto Project data so we've ensured uninative is there. Add the appropriate
> mirror url to make use of that.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/mirrors.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/mirrors.bbclass b/meta/classes/mirrors.bbclass
> index ba325a658bc..75eb86a7243 100644
> --- a/meta/classes/mirrors.bbclass
> +++ b/meta/classes/mirrors.bbclass
> @@ -62,6 +62,7 @@ ftp://.*/.*     http://sources.openembedded.org/ \n \
>  npm://.*/?.*    http://sources.openembedded.org/ \n \
>  ${CPAN_MIRROR}  http://cpan.metacpan.org/ \n \
>  ${CPAN_MIRROR}  http://search.cpan.org/CPAN/ \n \
> +https?$://downloads.yoctoproject.org/releases/uninative/ https://mirrors.kernel.org/yocto/uninative/ \n \

The above looked very odd to me, having that dollar sign in the middle of 
the regular expression. It wasn't until I was deep into the fetcher's code 
that I realized that it is not actually one regular expression above, but 
three, formatted as a URL...

However, based on the code in bitbake/lib/bb/fetch2/__init__.py:uri_replace(), 
AFAICT, the dollar sign should not be needed above, as it will be added for 
the URI type regexp automatically. The same goes for the other two URLs in 
mirrors.bbclass that use that formatting.

While investigating this, I also tried to look in the bitbake documentation 
for a description of the format used for the PREMIRRORS and MIRRORS variables, 
but I could not find any. There is only a simple example, without any 
explanation for the actual format that is being used.

>  "
> 
>  # Use MIRRORS to provide git repo fallbacks using the https protocol, for cases
> --
> 2.32.0

//Peter



  reply	other threads:[~2021-11-10 20:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 13:21 [PATCH] mirrors: Add uninative mirror on kernel.org Richard Purdie
2021-11-10 20:44 ` Peter Kjellerstedt [this message]
2021-11-10 20:54   ` [OE-core] " Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93b2df22824c47ff9c08365792a805d2@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox