public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Randy MacLeod <randy.macleod@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Sundeep KOKKONDA <sundeep.kokkonda@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] rust-cross-canadian: Fix for the linker issues caused by using the shell
Date: Tue, 6 Sep 2022 08:21:23 -0400	[thread overview]
Message-ID: <940b7e4b-02a2-0892-5d98-967328676180@windriver.com> (raw)
In-Reply-To: <c8062dc0c019bd8d09ef417d26cd7e83630baae4.camel@linuxfoundation.org>

On 2022-09-05 07:53, Richard Purdie wrote:
> On Mon, 2022-09-05 at 00:12 -0700, Sundeep KOKKONDA wrote:
>> Using CC args causing linker error "unknown executable format" so I
>> called linker directly.
>> Also, I wrote my initial code without any hardcoded symbols and that
>> test code works in my local machine but when the same code executed
>> in Yocto build environment SIGSEGV faults are reported. And to debug
>> the issue in Yocto build environment the printf/echo outputs are not
>> shown in console/log file. So, I modified my code to check whether
>> this solution works in AB machine or not.
>>
>> Can you let me know what is the error in AB machine
>> with unsetenv("LD_LIBRARY_PATH"); ? Is it the same relocation error?
> The issues would be due to the issues I mentioned in reply to your
> patch on the mailing list. The fixed length string and number of
> arguments issues.
>
> In the interests of moving forward, I put the binary shim in front of
> the shell script which can make the environment manipulations more
> easily.
>
> https://git.yoctoproject.org/poky/commit/?h=master-next&id=7a1bfb2f800c00d3d2bea9e20e5d31d32f247129
>
> The version of the code above seems to work, I ran some tests
> specifically on ubuntu1804.
>
> I added in some comments so we know in future why the code is doing
> this.
>
> I wondered if we could make that script MIT license rather than GPL-2.0
> just to try and keep our licensing fractionally simpler?
Yes, that should be fine. The rust code is dual-licensed

under Apache 2.0 and MIT  terms so we shouldn't be using GPL here.

Sundeep,
Please resend using an MIT license and Richard's changes linked above.

../Randy


>
> Cheers,
>
> Richard
>
>
>
>
>
>

-- 
# Randy MacLeod
# Wind River Linux



      reply	other threads:[~2022-09-06 12:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04 18:09 [PATCH] rust-cross-canadian: Fix for the linker issues caused by using the shell Sundeep KOKKONDA
2022-09-04 18:12 ` Sundeep KOKKONDA
2022-09-04 21:34 ` [OE-core] " Richard Purdie
     [not found] ` <1711C5DF821D6301.14041@lists.openembedded.org>
2022-09-04 22:01   ` Richard Purdie
2022-09-05  7:12     ` Sundeep KOKKONDA
2022-09-05 11:53       ` [OE-core] " Richard Purdie
2022-09-06 12:21         ` Randy MacLeod [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=940b7e4b-02a2-0892-5d98-967328676180@windriver.com \
    --to=randy.macleod@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=sundeep.kokkonda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox