On 2023-11-08 8:25 p.m., Randy MacLeod via lists.openembedded.org wrote:
From: Randy MacLeod <Randy.MacLeod@windriver.com>

When the helper scripts were split into separate packages, they
weren't added as ptest dependencies. Fix that.

Well, this is embarrassing...

I'm no longer convinced that this is required.

I think I saw the ../cg_diff errors below:

PASS: memcheck/tests/vcpu_fbench
PASS: memcheck/tests/wcs           
PASS: memcheck/tests/wcsncpy    
PASS: memcheck/tests/wmemcmp    
FAIL: memcheck/tests/wrap1  
FAIL: memcheck/tests/wrap2      
FAIL: memcheck/tests/wrap3       
FAIL: memcheck/tests/wrap4     
FAIL: memcheck/tests/wrap5    
FAIL: memcheck/tests/wrap6         
FAIL: memcheck/tests/wrap7      
FAIL: memcheck/tests/wrap8      
PASS: memcheck/tests/wrapmalloc   
PASS: memcheck/tests/wrapmallocstatic
PASS: memcheck/tests/writev1     
PASS: memcheck/tests/xml1          
python3: can't open file '/usr/lib/valgrind/ptest/cachegrind/tests/../cg_diff': [Errno 2] No such file or directory
post check failed: python3 ../cg_diff --mod-funcname="s/main/MAIN/" ann1.cgout ann1b.cgout > ann-diff1.cgout && python3 ../cg_annotate --mod-filename="s/a.c/A.c/" --mod-funcname s/MAIN/Main/
PASS: cachegrind/tests/ann-diff1
python3: can't open file '/usr/lib/valgrind/ptest/cachegrind/tests/../cg_diff': [Errno 2] No such file or directory
post check failed: python3 ../cg_diff --mod-filename="s/.*aux\//aux\//i" --mod-funcname="s/(f[a-z]*)[0-9]/\1N/g" ann-diff2a.cgout ann-diff2b.cgout > ann-diff2c.cgout && python3 ../cg_annotat
PASS: cachegrind/tests/ann-diff2

and made an assumption that may not be valid. I think this problem is still present
even after this change.

As I said previously, I may not have time to get back to this until next week so
if anyone picks up this work, they might want to confirm that this is really required.

I should have just waited until I had time to complete the update before spamming the list.

../Randy

../Randy



Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.21.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
index 68ab319a1b..a2feda6aae 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
@@ -139,7 +139,9 @@ RDEPENDS:${PN}-ptest += " bash coreutils curl file \
    perl-module-overloading perl-module-cwd perl-module-ipc-open3 \
    perl-module-carp perl-module-symbol \
    procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src gcc-runtime-dbg \
-   util-linux-taskset"
+   util-linux-taskset \
+   ${PN}-cachegrind ${PN}-massif ${PN}-callgrind \
+"
 RDEPENDS:${PN}-ptest:append:libc-glibc = " glibc-utils glibc-gconv-utf-32"
 
 # One of the tests contains a bogus interpreter path on purpose.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190367): https://lists.openembedded.org/g/openembedded-core/message/190367
Mute This Topic: https://lists.openembedded.org/mt/102477896/3616765
Group Owner: openembedded-core+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com]
-=-=-=-=-=-=-=-=-=-=-=-


-- 
# Randy MacLeod
# Wind River Linux