Re: [PATCH 3/4] pixman: upgrade 0.34.0 -> 0.38.0

["Mittal, Anuj" <anuj.mittal@intel.com>]

On Thu, 2019-02-14 at 07:58 -0800, Khem Raj wrote:
> On Wed, Feb 13, 2019 at 9:49 PM Anuj Mittal <anuj.mittal@intel.com>
> wrote:
> > 
> > For changes, see:
> > 
> > 
https://cgit.freedesktop.org/pixman/log/?qt=range&q=pixman-0.38.0...pixman-0.34.0
> > 
> > Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
> > ---
> >  .../xorg-lib/pixman/asm_include.patch         | 29 -------------
> > ------
> >  .../{pixman_0.34.0.bb => pixman_0.38.0.bb}    |  5 ++--
> >  2 files changed, 2 insertions(+), 32 deletions(-)
> >  delete mode 100644 meta/recipes-graphics/xorg-
> > lib/pixman/asm_include.patch
> >  rename meta/recipes-graphics/xorg-lib/{pixman_0.34.0.bb =>
> > pixman_0.38.0.bb} (89%)
> > 
> > diff --git a/meta/recipes-graphics/xorg-
> > lib/pixman/asm_include.patch b/meta/recipes-graphics/xorg-
> > lib/pixman/asm_include.patch
> > deleted file mode 100644
> > index b52a5707d6..0000000000
> > --- a/meta/recipes-graphics/xorg-lib/pixman/asm_include.patch
> > +++ /dev/null
> > @@ -1,29 +0,0 @@
> > -Fixes errors like
> > -
> > -Assembler messages:
> > -Fatal error: can't create .libs/pixman-mips-dspr2-asm.o: No such
> > file or directory
> > -
> > -it works with glibc because it uses gcc fixed-headers but thats
> > not right.
> > -
> > -We move the include under C block
> > -
> > -Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > -Upstream-Status: Pending
> > -Index: pixman-0.32.6/pixman/pixman-private.h
> > -==================================================================
> > =
> > ---- pixman-0.32.6.orig/pixman/pixman-private.h
> > -+++ pixman-0.32.6/pixman/pixman-private.h
> > -@@ -1,4 +1,3 @@
> > --#include <float.h>
> > -
> > - #ifndef PIXMAN_PRIVATE_H
> > - #define PIXMAN_PRIVATE_H
> > -@@ -17,6 +16,8 @@
> > -
> > - #ifndef __ASSEMBLER__
> > -
> > -+#include <float.h>
> > -+
> > - #ifndef PACKAGE
> > - #  error config.h must be included before pixman-private.h
> > - #endif
> > diff --git a/meta/recipes-graphics/xorg-lib/pixman_0.34.0.bb
> > b/meta/recipes-graphics/xorg-lib/pixman_0.38.0.bb
> > similarity index 89%
> > rename from meta/recipes-graphics/xorg-lib/pixman_0.34.0.bb
> > rename to meta/recipes-graphics/xorg-lib/pixman_0.38.0.bb
> > index c290fa4614..49c3d62342 100644
> > --- a/meta/recipes-graphics/xorg-lib/pixman_0.34.0.bb
> > +++ b/meta/recipes-graphics/xorg-lib/pixman_0.38.0.bb
> > @@ -31,11 +31,10 @@ EXTRA_OECONF_class-nativesdk = "--disable-gtk"
> > 
> >  SRC_URI += "\
> >              file://0001-ARM-qemu-related-workarounds-in-cpu-
> > features-detecti.patch \
> > -           file://asm_include.patch \
> 
> can you confirm you tested a build with musl/mips ?

I tested with musl. The change is also present upstream now:


https://cgit.freedesktop.org/pixman/commit/?id=7c6066b700c7cdd4aeb8be426b14b3a5f0de4b6c