From: "Luca Bocassi" <luca.boccassi@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3] dbus: split -common and -tools out of main package
Date: Fri, 13 Nov 2020 14:50:44 +0000 [thread overview]
Message-ID: <94ba394eab9d749eb0fdcab230940897bdcd3422.camel@gmail.com> (raw)
In-Reply-To: <bb0f046569d419d636a6ca08be6b0b57fa64bfdf.camel@linuxfoundation.org>
On Fri, 2020-11-13 at 14:34 +0000, Richard Purdie wrote:
> On Fri, 2020-11-13 at 10:47 +0000, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Certain config files and units are shared between dbus-daemon and
> > dbus-broker (available in meta-openembedded), so split them out to
> > allow installing dbus-broker without pulling in dbus-daemon and its
> > dependencies.
> > Stand-alone command line tools can also be used regardless of whether
> > the buses are provided by dbus-daemon or dbus-broker, so split them
> > out into dbus-tools.
> > Finally, move the XML schema files out of the main package and into
> > the development package.
> >
> > All these changes follow the same pattern used by Fedora, which was
> > one of the first distro to switch to dbus-broker by default:
> >
> > https://src.fedoraproject.org/rpms/dbus/blob/master/f/dbus.spec
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > v2: fix FILES_ regex to correctly include all units but the sockets
> > in the main package
> > v3: do not use ${PN} in RDEPENDS, as bitbake expansion is broken and
> > generates wrong values (eg: dbus-native-common-native)
>
> Without testing I can tell this will break multilib.
>
> RDEPENDS and native are a little confusing and tricky, basically due to
> legacy. This is why you'll see RDEPENDS_${PN}_class-native = "" and
> that is probably what is needed here.
>
> Cheers,
>
> Richard
Ok, sent a v4, even though I really do not follow - there's already
this in the recipe:
RDEPENDS_dbus_class-native = ""
Also won't that mean that for native builds there's no dependency, thus
breaking the dbus package (the required conf is no longer installed)?
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2020-11-13 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 18:05 [PATCH] dbus: split -common and -tools out of main package Luca Bocassi
2020-11-02 19:18 ` [PATCH v2] " Luca Bocassi
2020-11-11 10:32 ` Luca Boccassi
2020-11-12 17:29 ` [OE-core] " Richard Purdie
2020-11-12 17:53 ` Luca Boccassi
2020-11-13 10:47 ` [PATCH v3] " Luca Bocassi
2020-11-13 14:34 ` Richard Purdie
2020-11-13 14:50 ` Luca Bocassi [this message]
2020-11-13 14:50 ` [PATCH v4] " Luca Bocassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94ba394eab9d749eb0fdcab230940897bdcd3422.camel@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox