From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mail.openembedded.org (Postfix) with ESMTP id B0C4F783F7 for ; Wed, 6 Dec 2017 11:50:58 +0000 (UTC) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 03:50:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,367,1508828400"; d="scan'208";a="544831" Received: from jlock-mobl3.ger.corp.intel.com ([10.252.20.38]) by orsmga008.jf.intel.com with ESMTP; 06 Dec 2017 03:50:59 -0800 To: openembedded-core@lists.openembedded.org References: <20171205155142.190886-1-leonardo.sandoval.gonzalez@linux.intel.com> From: Joshua Lock Message-ID: <94bca5d9-9b8d-814b-f464-e470dfddac15@linux.intel.com> Date: Wed, 6 Dec 2017 11:50:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171205155142.190886-1-leonardo.sandoval.gonzalez@linux.intel.com> Subject: Re: [PATCH] core/loader.py: fix regex to include all available test cases X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 11:50:58 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 05/12/17 15:51, leonardo.sandoval.gonzalez@linux.intel.com wrote: > From: Leonardo Sandoval > > Some test cases (i.e. eSDK.oeSDKExtSelfTest*) does not match with current regex, > fix it to accept these (and previous ones). > > Without it, the following runtime exception is observed when executing eSDK > selftest (oe-selftest -r eSDK) > > Traceback (most recent call last): > File "/openembedded-core/scripts/oe-selftest", line 70, in > ret = main() > File "/openembedded-core/scripts/oe-selftest", line 57, in main > results = args.func(logger, args) > File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 253, in run > rc = self._internal_run(logger, args) > File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 205, in _internal_run > self.tc.loadTests(self.module_paths, **self.tc_kwargs['load']) > File "/openembedded-core/meta/lib/oeqa/core/context.py", line 58, in loadTests > modules_required, filters) > File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 69, in __init__ > self.modules = _built_modules_dict(modules) > File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 48, in _built_modules_dict > module_name, class_name, test_name = m.groups() > AttributeError: 'NoneType' object has no attribute 'groups' > > Signed-off-by: Leonardo Sandoval LGTM and fixes [YOCTO #12385], thanks! Acked-by: Joshua Lock > --- > meta/lib/oeqa/core/loader.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/lib/oeqa/core/loader.py b/meta/lib/oeqa/core/loader.py > index 975a081ba4..9ab4df0a60 100644 > --- a/meta/lib/oeqa/core/loader.py > +++ b/meta/lib/oeqa/core/loader.py > @@ -43,7 +43,7 @@ def _built_modules_dict(modules): > for module in modules: > # Assumption: package and module names do not contain upper case > # characters, whereas class names do > - m = re.match(r'^([^A-Z]+)(?:\.([A-Z][^.]*)(?:\.([^.]+))?)?$', module) > + m = re.match(r'^([a-zA-Z]+)(?:\.([a-zA-Z][^.]*)(?:\.([^.]+))?)?$', module) > > module_name, class_name, test_name = m.groups() > >