From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paulo Neves <ptsneves@gmail.com>,
OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH 1/3] testimage: Refactoring and fixing.
Date: Mon, 13 Aug 2018 15:33:26 +0100 [thread overview]
Message-ID: <94fdc59922b11cf74ec789ffbaa4745ca3bc8ead.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJO0J4ig3xhEaukBrZFw2RCMzpXjbuXXFiMt8vP2edpsA8Wdxw@mail.gmail.com>
On Sun, 2018-08-12 at 21:49 +0200, Paulo Neves wrote:
> I found a bug in my code where changing a variable, for example in
> layer.conf does not re-trigger the generation of the json file
> containing the data store at the time of image creation. The json
> file is generated in
> ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data ; " @
> meta/classes/rootfs-postcommands.bbclass.
>
> Can anybody tell me if changing a variable in the datastore and
> accessing it in the postprocess_command will never trigger the
> postprocess_command? It happens that in this case this variable is
> not important for the rootfs task itself but only for the post-
> process.
The system has no insight into which variables that command might be
accessing so it doesn't know when to rerun it. Adding a dependency on
all variables would mean the rootfs would get continually rewritten.
I don't like the json usage in testimage for this reason as it
effectively breaks our data dependencies and handling in order to be
able to run standalone. Pros and cons I guess, this is one of the
downsides. Not sure there is much that can be done about it.
Cheers,
Richard
next prev parent reply other threads:[~2018-08-13 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 19:37 [meta-oe][PATCH 1/3] testimage: Refactoring and fixing Paulo Neves
2018-08-10 19:37 ` [meta-oe][PATCH 2/3] testimage: target.start exceptions not masked Paulo Neves
2018-08-10 19:37 ` [meta-oe][PATCH 3/3] masterimage: Check for rootfs path instead of file Paulo Neves
2018-08-11 12:29 ` [meta-oe][PATCH 1/3] testimage: Refactoring and fixing Richard Purdie
2018-08-12 19:49 ` Paulo Neves
2018-08-13 14:33 ` Richard Purdie [this message]
2018-08-18 16:40 ` Paulo Neves
2018-08-19 22:14 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94fdc59922b11cf74ec789ffbaa4745ca3bc8ead.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=ptsneves@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox