Re: [PATCH] oe_syslog.py: Handle syslogd/klogd restart race

[richard.purdie@linuxfoundation.org]

On Fri, 2019-06-21 at 15:26 -0400, Jon Mason wrote:
> On Fri, Jun 21, 2019 at 1:44 PM Jon Mason <jdmason@kudzu.us> wrote:
> > On Fri, Jun 21, 2019 at 12:58 PM <
> > richard.purdie@linuxfoundation.org> wrote:
> > > 
> > > I realise there is slightly more overhead but it might give us
> > > more
> > > chance of fixing all the races?
> > 
> > 4 extra function calls would almost be statistical noise.  I'll
> > code
> > it up to do the check every time regardless and add it for each
> > syslogd/klogd call.
> 
> A timed run of testimage on a Cortex A57x4 system (with KVM enabled)
> went from ~1m21s (1m23s, 1m22s,1m20s) to ~1m23s (1m22s, 1m25s,
> 1m24s).
> Without KVM enabled, it went from 20m6s to 20m56s. It's possible with
> a larger sample size that they would converge even more, but I think
> this is sufficient to show it's not a deal breaker to run it every
> time.

Sound good to me, thanks! :)

Cheers,

Richard