public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Joshua Watt" <JPEWhacker@gmail.com>,
	"Piotr Łobacz" <p.lobacz@welotec.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	Alex Stewart <alex.stewart@ni.com>
Subject: Re: [OE-Core][PATCH v11][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr
Date: Mon, 31 Jul 2023 22:19:39 +0100	[thread overview]
Message-ID: <972083f47f3513fada3dc64c233f2c229f952aca.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJdd5GYifrOT_9-fct6TT95sw6tDe0L7etLxOcaEgTTGvWFPJg@mail.gmail.com>

On Mon, 2023-07-31 at 14:25 -0600, Joshua Watt wrote:
> On Mon, Jul 31, 2023 at 1:10 PM Piotr Łobacz <p.lobacz@welotec.com> wrote:
> > 
> > I’m sorry for splitting this message but it has happend by accident…
> > 
> > Returning to the topic my assumption is that for some reason in reproducibleA, these miliseconds are cutted and in case of reproducibleB they are not.
> > 
> > This was obviously working for opkg-build in case of gnu format which is cutting it also but for posix format it stores and thus error occurs.
> > 
> > My question is where can I find the code responsible for moving/coping data into these packages-split directories?
> 
> I suspect this is because reproducibleA is allowed to restore from
> sstate where the milliseconds are not preserved, while reproducibleB
> doesn't restore from sstate.
> 
> I'm not sure how you would store the milliseconds in sstate and make
> sure it was consistent, but that is probably where you need to look.
> Start in sstate.bbclass

What is likely happening is that we have two cases:

a) do_package is run and do_package_write_ipk uses the files directly
from disk which has the millisecond data. do_package writes an sstate
tarball using tar in non-posix mode.

b) do_package_setscene runs instead of do_package. This restores the
tarball written into sstate in a). The millisecond data is therefore
lost. do_package_write_ipk would then be written without it.

I'd guess you need to make the sstate archives of do_package store the
acl and extended attribute data and when that is done, the millisecond
timestamp data will probably be saved too? I'm not sure this is going
to be a generally useful thing in the general case though and zeroing
the millisecond portion would really be easier in general if we could.
Certainly, SOURCE_DATE_EPOCH doesn't have millisecond precision.

Cheers,

Richard






  reply	other threads:[~2023-07-31 21:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  9:22 [OE-Core][PATCH v11][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
2023-07-26  9:22 ` [OE-Core][PATCH v11][master-next 2/5] package.bbclass: " Piotr Łobacz
2023-07-26  9:22 ` [OE-Core][PATCH v11][master-next 3/5] opkg-utils: add acl and xattr support Piotr Łobacz
2023-07-26  9:22 ` [OE-Core][PATCH v11][master-next 4/5] opkg: add options to enable support for acl and xattr Piotr Łobacz
2023-07-26  9:22 ` [OE-Core][PATCH v11][master-next 5/5] opkg: set locale from system environment variables Piotr Łobacz
2023-07-26  9:27 ` ODP: [OE-Core][PATCH v11][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Piotr Łobacz
2023-07-27 14:18   ` Alexandre Belloni
2023-07-27 15:30     ` ODP: " Piotr Łobacz
2023-07-28 22:58     ` Piotr Łobacz
     [not found]     ` <17762A3A069807A3.31298@lists.openembedded.org>
2023-07-31 19:03       ` Piotr Łobacz
2023-07-31 19:09         ` Piotr Łobacz
2023-07-31 20:25           ` Joshua Watt
2023-07-31 21:19             ` Richard Purdie [this message]
2023-07-31 21:23               ` Piotr Łobacz
     [not found]               ` <177710C9CE043B33.12785@lists.openembedded.org>
2023-07-31 21:28                 ` ODP: " Piotr Łobacz
2023-08-01 13:04                   ` Martin Jansa
2023-08-01 13:27                     ` ODP: " Piotr Łobacz
     [not found]                     ` <1777455C95C57250.15736@lists.openembedded.org>
2023-08-01 15:16                       ` Piotr Łobacz
2023-08-01 15:41                         ` Richard Purdie
2023-08-01 16:00                           ` ODP: " Piotr Łobacz
     [not found]                           ` <17774DB8C4C2BE4F.15736@lists.openembedded.org>
2023-08-02  1:17                             ` Piotr Łobacz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=972083f47f3513fada3dc64c233f2c229f952aca.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=JPEWhacker@gmail.com \
    --cc=alex.stewart@ni.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=p.lobacz@welotec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox