Re: [OE-core] [PATCH] gstreamer1.0-plugins-bad: add ANY_OF_DISTRO_FEATURES

[Changqing Li <changqing.li@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 2812 bytes --]


On 4/13/26 23:42, Mathieu Dubois-Briand wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Thu Mar 19, 2026 at 2:54 AM CET, Changqing Li via lists.openembedded.org wrote:
>> When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
>> do_configure will failed with error:
>> gst-libs/gst/vulkan/meson.build:311:4: ERROR: Problem encountered: No Windowing system found. vulkansink will not work
>>
>> set ANY_OF_DISTRO_FEATURES to make gstreamer1.0-plugins-bad build only
>> when x11 or wayland is enabled.
>>
>> Signed-off-by: Changqing Li<changqing.li@windriver.com>
>> ---
> Hi Changqing,
>
> Thanks for your patch.
>
>>   .../gstreamer/gstreamer1.0-plugins-bad_1.26.9.bb              | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.26.9.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.26.9.bb
>> index 4a9cb37dd8..2cb00f180f 100644
>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.26.9.bb
>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.26.9.bb
>> @@ -19,7 +19,9 @@ LIC_FILES_CHKSUM ="file://COPYING;md5=4fbd65380cdd255951079008b364516c"
>>
>>   DEPENDS += "gstreamer1.0-plugins-base"
>>
>> -inherit gobject-introspection
>> +inherit gobject-introspection features_check
>> +
>> +ANY_OF_DISTRO_FEATURES ="${@bb.utils.contains('DISTRO_FEATURES', 'vulkan', 'x11 wayland', '', 
>> d)}"
> So the error we get if we try to build with "vulkan" in DISTRO_FEATURES
> but not "x11" not "wayland" is the following:
>
> ERROR: Nothing PROVIDES 'gstreamer1.0-plugins-bad'
> gstreamer1.0-plugins-bad was skipped: one of 'wayland x11' needs to be in DISTRO_FEATURES

yes, if user bitbake gstreamer1.0-plugins-bad, this will be reported.

And this fix will unblock "bitbake world" since gstreamer1.0-plugins-bad 
is skipped

>
> To be honest, I believe this is a bit misleading, as we are not
> mentioning the vulkan DISTRO_FEATURES, while this is the main issue:
> gstreamer1.0-plugins-bad can be built without wayland or x11, just not
> with vulkan.
user only can get why by checking recipe settings
>
> I would really prefer a better error message, but otherwise we should at
> least add some comment in the recipe explaining why we have this
> ANY_OF_DISTRO_FEATURES line.

I send a V2 to add a comment,  user need to check the comments and 
commit message

to know why ANY_OF_DISTRO_FEATURES is added.

Regards

//changqing

>
> Thanks,
> Mathieu
>
> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>

[-- Attachment #2: Type: text/html, Size: 4521 bytes --]