Re: [PATCH] initscripts: populate-volatiles: Speed up processing

[Joshua Watt <jpewhacker@gmail.com>]

On Fri, 2018-10-12 at 08:33 +0100, Richard Purdie wrote:
> On Thu, 2018-10-11 at 13:08 -0500, Joshua Watt wrote:
> > Checking the requirements for each volatiles file in the
> > populate-volatiles script can be very slow when there are a large
> > number
> > of volatiles files, easily consuming over 80% of the processing
> > time.
> > These checks don't usually uncover any problems so concatenate all
> > the
> > volatiles files together and process them as one large file for a
> > "fast
> > path" option. This ensures that the penalty for checking the
> > requirements is only incurred once. In the event that checking the
> > requirements for the unified file fails, fall back to the slow
> > process
> > of checking each one individually so that the offending one can be
> > skipped.
> > 
> > [YOCTO #12949]
> > 
> > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> 
> As yet I little evidence for it but I think this caused: 

Yep, this was caused by my change. Turns out that for whatever reason
this configuration doesn't have /var/volatile/tmp created before
populate-volatiles.sh is run... not sure exactly *why* that is
different, but this is actually the reason that the 00_core volatile
file requirements aren't checked (e.g. there is no tmp directory to put
the files until it is done).

Anyway, the fix is fairly simple. V2 is coming shortly.

> 
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/35/builds/69/
> steps/7/logs/step6c
> 
> You can see the config in:
> 
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/35/builds/69/
> steps/7/logs/stdio
> 
> the key bits for 6c are:
> 
> DISTRO_FEATURES_append = ' systemd'
> VIRTUAL-RUNTIME_init_manager = 'sysvinit'
> 
> Cheers,
> 
> Richard
> 
-- 
Joshua Watt <JPEWhacker@gmail.com>