Re: [OE-core] [PATCH v3 2/2] shadow: link executables statically for -native variant

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2024-01-18 at 15:37 +0200, Dmitry Baryshkov wrote:
> On Thu, 18 Jan 2024 at 11:59, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > On Wed, 2024-01-17 at 14:46 +0200, Dmitry Baryshkov wrote:
> > > On Thu, 11 Jan 2024 at 15:15, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
> > > > 
> > > > shadow 4.14.x adds a number of libraries it dynamically links with
> > > > (md, bsd, attr). This causes troubles in setscene tasks where
> > > > shadow executables are used (such as useradd), as pulling in
> > > > the needed dynamic libraries needs unpleasant special-casing.
> > > > 
> > > > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> > > 
> > > It seems, this is causing issues with the TuxOE builds. We have been
> > > observing issues with the TuxOE build environment with the image
> > > creation choking on the home dirs. Reverting this patch seems to fix
> > > the problem. The build environment is Ubuntu 20.04 running in a
> > > container on Ubuntu 22.04.
> > > 
> > > ERROR: rpb-weston-image-1.0-r0 do_image_tar:
> > > ExecutionError('/oe/build/tmp-rpb_wayland-glibc/work/qcom_armv8a-linaro-linux/rpb-weston-image/1.0/temp/run.do_image_tar.160075',
> > > 1, None, None)
> > > ERROR: Logfile of failure stored in:
> > > /oe/build/tmp-rpb_wayland-glibc/work/qcom_armv8a-linaro-linux/rpb-weston-image/1.0/temp/log.do_image_tar.160075
> > > Log data follows:
> > > > DEBUG: Executing python function set_image_size
> > > > DEBUG: 1402908.000000 = 1079160 * 1.300000
> > > > DEBUG: 1402908.000000 = max(1402908.000000, 65536)[1402908.000000] + 0
> > > > DEBUG: 1402908.000000 = int(1402908.000000)
> > > > DEBUG: 1404928 = aligned(1402908)
> > > > DEBUG: returning 1404928
> > > > DEBUG: Python function set_image_size finished
> > > > DEBUG: Executing shell function do_image_tar
> > > > tar: ./home/linaro/.bashrc: Unknown file type; file ignored
> > > > tar: ./home/linaro/.profile: Unknown file type; file ignored
> > > > tar: Exiting with failure status due to previous errors
> > > > WARNING: /oe/build/tmp-rpb_wayland-glibc/work/qcom_armv8a-linaro-linux/rpb-weston-image/1.0/temp/run.do_image_tar.160075:146
> > > exit 1 from '[ $? -eq 1 ]'
> > > 
> > 
> > The error is coming from tar during archive creation, "Unknown file
> > type; file ignored". I'm a little confused/concerned about what it is
> > seeing which it can't handle.
> > 
> > It might also be good to work out if that is tar from the host or tar
> > from tar-native. Is the host's tar unable to support something we're
> > relying upon?
> > 
> > If it were me, I'd probably have a look into the tar source code too,
> > see what might trigger an error like that.
> 
> I compared this to the ext4 creation error. The code for __populate_fs
> is more easy to follow. Basically this error means that st.st_mode
> doesn't match S_IFCHR, S_IFBLK, S_IFREG and S_IFDIR checks.
> I assume the files in home dir are created by useradd in some way that
> bypasses pseudo. Then when tar / mkfs are executed, pseudo doesn't
> know about the file and returns bad st_mode through lstat().

Files shouldn't be getting created in useradd that pseudo doesn't know
about. If they are, we could be missing an intercept on some glibc
function call for example.

Is this in a multiple worker setup with a shared sstate? We need to
track down which OS the escape is happening on. In theory it should be
reproducible. Do you have anything with a bleeding edge glibc there
(e.g. gentoo)?

Cheers,

Richard