public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Yash.Shinde@windriver.com, openembedded-core@lists.openembedded.org
Cc: Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com
Subject: Re: [OE-core] [PATCH] cargo: Drop cargo wrapper to ensure successfull cargo builds in SDK
Date: Tue, 21 Jan 2025 11:02:16 +0000	[thread overview]
Message-ID: <9aedbeaccf400910bd83d5b9e4405ce5eaa173d7.camel@linuxfoundation.org> (raw)
In-Reply-To: <20250121105402.733009-1-Yash.Shinde@windriver.com>

On Tue, 2025-01-21 at 02:54 -0800, Yash Shinde via lists.openembedded.org wrote:
> From: Yash Shinde <Yash.Shinde@windriver.com>
> 
> - The SDK uses a cargo wrapper that sets LD_LIBRARY_PATH to point to SDK target library directory.
>   This wrapper was added to resolve library path errors by including libdir and base_dir paths
>   in LD_LIBRARY_PATH for tumbleweed-ty-3 distro.
>   (https://git.openembedded.org/openembedded-core/commit/?id=388e7cac9f90e79ce8c3c1683d8ee0f4df1bc907)
> 
> - But, a simple 'cargo build' in SDK env caused failures for certain crates due to
>   undefined symbol and broken C compiler in SDK. Removing the cargo wrapper builds the crate
>   successfully.
> 
> - With tumbleweed no longer being part of the tested distributions, drop the cargo wrapper that was
>   previously added to address library loading issues on it.
>   This resolves the errors seen with 'cargo build' in SDK env.
> 
> References:
> Tumbleweed removal: https://git.yoctoproject.org/yocto-autobuilder2/commit/?id=96e82ce670c02b166398500435c2df455b09b951
> List of tested distros: https://git.yoctoproject.org/yocto-autobuilder2/tree/config.py?id=694d2a9bae523d9396b37da9cc6535a558e04d81#n168
> 
> Fixes [YOCTO #15579]
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=15579
> 
> Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
> ---
>  meta/recipes-devtools/rust/cargo_1.81.0.bb | 8 --------
>  1 file changed, 8 deletions(-)

Even if we're not testing on tumbleweed, there is an interaction issue
here and this interaction is going to come back and bite us with some
new combination of host and nativesdk glibc.

I'm therefore not convinced that simply removing this is a great idea,
we need to find a way to address the underlying issue.

Cheers,

Richard


      reply	other threads:[~2025-01-21 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 10:54 [PATCH] cargo: Drop cargo wrapper to ensure successfull cargo builds in SDK Yash.Shinde
2025-01-21 11:02 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aedbeaccf400910bd83d5b9e4405ce5eaa173d7.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Randy.MacLeod@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=Yash.Shinde@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox