Re: [OE-core] [PATCH 1/2] kernel-kfrag: add new class

["Armin Kuster" <akuster808@gmail.com>]

On 5/30/21 1:47 PM, Bruce Ashfield wrote:
> On Sun, May 30, 2021 at 2:06 PM Armin Kuster <akuster808@gmail.com> wrote:
>> This provides a common place to define kernel fragments
>> that may be usefull to the larger community.
> Not a bad idea at all, but what about calling the class
> "kernel-features", versus kfrag ? That describes the purpose, versus
> what the mechanism does.
works for me.
>
> A 2nd suggestion would be to bbwarn if this is inherited, but
> kernel-yocto is not.
seems reasonable.  I did wonder the best place to place for thie. The
kernel cache can be used w/o linux-yocto.
>
> Note: as mentioned during the yocto summit, I do have patches that
> make fragments more universally available, when I get them ready, we
> could remove the bbwarn.
Would those patches eliminate the need for a class like this?

-armin
>
> Bruce
>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>  meta/classes/kernel-kfrag.bbclass | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>  create mode 100644 meta/classes/kernel-kfrag.bbclass
>>
>> diff --git a/meta/classes/kernel-kfrag.bbclass b/meta/classes/kernel-kfrag.bbclass
>> new file mode 100644
>> index 00000000000..c0c5667b519
>> --- /dev/null
>> +++ b/meta/classes/kernel-kfrag.bbclass
>> @@ -0,0 +1,8 @@
>> +#
>> +# Class to place yocto-kernel-cache fragments
>> +# selections usfull to anyone
>> +#
>> +
>> +KERNEL_FEATURES_append = " ${@bb.utils.contains("DISTRO_FEATURES", "apparmor", " features/apparmor/apparmor.scc", "" ,d)}"
>> +KERNEL_FEATURES_append = " ${@bb.utils.contains("DISTRO_FEATURES", "smack", " features/smack/smack.scc", "" ,d)}"
>> +KERNEL_FEATURES_append = " ${@bb.utils.contains("DISTRO_FEATURES", "dm-verity", " features/device-mapper/dm-verity.scc", "" ,d)}"
>> --
>> 2.24.3
>>
>>
>> 
>>
>