From: "Changqing Li" <changqing.li@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] buildtools-tarball: add wic dependency into buildtools
Date: Wed, 25 Nov 2020 08:47:16 +0800 [thread overview]
Message-ID: <9bdd286d-402c-0090-8089-23adfa2cd746@windriver.com> (raw)
In-Reply-To: <fdd3fff795db407382604abaad4f6173d7028a9a.camel@linuxfoundation.org>
On 20/11/20 7:07 pm, Richard Purdie wrote:
> [Please note this e-mail is from an EXTERNAL e-mail address]
>
> On Thu, 2020-11-19 at 08:48 +0800, Changqing Li wrote:
>> fix below error:
>> wic ls ./core-image-minimal-intel-x86-64.wic
>>
>> ERROR: Can't find executable parted
>>
>> wic depend on some tools like parted/mtools/..., and we have those
>> tools in native_sysroot. so above problem can be avoided by
>> run command like wic ls imagename.wic --native-sysroot <path>
>>
>> but this cannot cover condition that usr don't have build the
>> image, the image just copy from somewhere.
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>> meta/recipes-core/meta/buildtools-tarball.bb | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-core/meta/buildtools-tarball.bb
>> b/meta/recipes-core/meta/buildtools-tarball.bb
>> index 560b8d67b9..7783fabbf2 100644
>> --- a/meta/recipes-core/meta/buildtools-tarball.bb
>> +++ b/meta/recipes-core/meta/buildtools-tarball.bb
>> @@ -29,6 +29,9 @@ TOOLCHAIN_HOST_TASK ?= "\
>> nativesdk-rpcsvc-proto \
>> nativesdk-patch \
>> nativesdk-mtools \
>> + nativesdk-parted \
>> + nativesdk-dosfstools \
>> + nativesdk-gptfdisk \
>> "
> These sound more like something which would be in buildtools-extended-
> tarball. Our rough metric for inclusion in this recipe is whether the
> tools are needed by an OE build and these are not, they're only needed
> for standalone wic usage. I'm therefore unsure whether we should be
> adding them at all.
>
> Any other opinions?
>
> Cheers,
> Richard
ok. I will send a v2 to add them into buildtools-extended-tarbal. Thanks.
changqing
>
prev parent reply other threads:[~2020-11-25 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 0:48 [PATCH] buildtools-tarball: add wic dependency into buildtools Changqing Li
2020-11-20 11:07 ` [OE-core] " Richard Purdie
2020-11-25 0:47 ` Changqing Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bdd286d-402c-0090-8089-23adfa2cd746@windriver.com \
--to=changqing.li@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox