From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chen Qi <Qi.Chen@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] glibc: refresh patch to also fix qemuppc
Date: Sat, 29 Sep 2018 13:26:10 +0100 [thread overview]
Message-ID: <9e2836e7ec7b062fe9bcf06a498eea30f983eb65.camel@linuxfoundation.org> (raw)
In-Reply-To: <7e21f0e0a9d537ea22ccebab46ce5e4f4912d5ba.1538189779.git.Qi.Chen@windriver.com>
On Sat, 2018-09-29 at 10:58 +0800, Chen Qi wrote:
> The patch 0031-sysdeps-ieee754-prevent-maybe-uninitialized-
> errors.patch
> did not take into consideration of qemuppc. Refresh it to also fix
> building for qemuppc.
>
> The related error message is like below:
>
> ../sysdeps/ieee754/ldbl-128ibm/e_jnl.c:153:20: error: 'temp' may be
> used uninitialized in this function [-Werror=maybe-uninitialized]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> ...eee754-prevent-maybe-uninitialized-errors.patch | 41
> +++++++++++++++++-----
> 1 file changed, 32 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-
> prevent-maybe-uninitialized-errors.patch b/meta/recipes-
> core/glibc/glibc/0031-sysdeps-ieee754-prevent-maybe-uninitialized-
> errors.patch
> index b02c4ec..1c5b254 100644
> --- a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent-
> maybe-uninitialized-errors.patch
> +++ b/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent-
> maybe-uninitialized-errors.patch
> @@ -1,4 +1,4 @@
> -From c6cc5a6ef46837e341fe271b5ffa6def23810082 Mon Sep 17 00:00:00
> 2001
> +From 113241a738662854256c5e2e415397721b842862 Mon Sep 17 00:00:00
> 2001
> From: Martin Jansa <Martin.Jansa@gmail.com>
> Date: Fri, 14 Sep 2018 23:23:03 +0000
> Subject: [PATCH] sysdeps/ieee754: prevent maybe-uninitialized errors
> @@ -21,13 +21,14 @@ Upstream-Status: Submitted [https://www.sourcewar
> e.org/ml/libc-alpha/2018-09/msg
I get nervous when we modify a patch submitted upstream. Was the patch
submitted accepted? Do we need to send this other piece upstream?
Cheers,
Richard
next prev parent reply other threads:[~2018-09-29 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 2:58 [PATCH 0/1] glibc: refresh patch to also fix qemuppc Chen Qi
2018-09-29 2:58 ` [PATCH 1/1] " Chen Qi
2018-09-29 12:26 ` Richard Purdie [this message]
2018-09-29 12:55 ` Martin Jansa
2018-09-30 16:27 ` [PATCH] glibc: bump SRCREV to latest 2.28 Martin Jansa
2018-09-30 16:36 ` Khem Raj
2018-10-09 2:01 ` [PATCH 1/1] glibc: refresh patch to also fix qemuppc ChenQi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e2836e7ec7b062fe9bcf06a498eea30f983eb65.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox