Re: [PATCH v5 05/10] bitbake.conf: add ip and scp to HOSTTOOLS unconditionally

[ChenQi <Qi.Chen@windriver.com>]

On 10/27/2017 06:07 PM, Markus Lehtonen wrote:
> Needed to be able to run images using the runtime test facilities.

Hi Markus,

What do you mean by 'run images using runtime test facilities'?
testimage? ptest?
'scp' and 'ip' are added to HOSTTOOLS if 'testimage' is inherited.
What's the use case that still needs 'scp' and 'ip' unconditionally?

In addition, if we add these two utilities to HOSTTOOLS unconditionally.
Please cc to doc people to also change the QuickStart.

Regards,
Chen Qi

> Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
> ---
>   meta/conf/bitbake.conf | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 9696273acc..9075d03998 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -476,15 +476,15 @@ HOSTTOOLS += " \
>       [ ar as awk basename bash bzip2 cat chgrp chmod chown chrpath cmp cp cpio \
>       cpp cut date dd diff diffstat dirname du echo egrep env expand expr false \
>       fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \
> -    head hostname id install ld ldd ln ls make makeinfo md5sum mkdir mknod \
> +    head hostname id install ip ld ldd ln ls make makeinfo md5sum mkdir mknod \
>       mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
> -    python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
> +    python2.7 python3 ranlib readelf readlink rm rmdir rpcgen scp sed sh sha256sum \
>       sleep sort split stat strings strip tail tar tee test touch tr true uname \
>       uniq wc wget which xargs \
>   "
>   
>   # Tools needed to run testimage runtime image testing
> -HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
> +HOSTTOOLS += "${@['', 'ping ps ssh stty'][bb.data.inherits_class('testimage', d)]}"
>   
>   # Link to these if present
>   HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"