Re: [PATCH] apr_cv_mutex_recursive=yes added to apr_1.4.6.bb to make rosnodes work

From: Khem Raj <raj.khem@gmail.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: vmayoral <v.mayoralv@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] apr_cv_mutex_recursive=yes added to apr_1.4.6.bb to make rosnodes work
Date: Wed, 3 Jul 2013 13:19:11 -0700	[thread overview]
Message-ID: <A0A781A4-41F4-47AC-954B-C3E55283B32F@gmail.com> (raw)
In-Reply-To: <51D4857E.9060602@linux.intel.com>

On Jul 3, 2013, at 1:11 PM, Saul Wold <sgw@linux.intel.com> wrote:

> On 07/03/2013 06:04 AM, vmayoral wrote:
>> From: victor <v.mayoralv@gmail.com>
>> 
>> Working with the meta-ros project we detected that the ROS nodes didn't launch properly
>> the reason was that by default apr_cv_mutex_recursive in apr is set to no and this leads
>> to the APRENOTIMPL return value of apr_thread_mutex_create in thread_mutex.c when
>> APR_THREAD_MUTEX_NESTED is requested via flags.
>> 
>> Added CACHED_CONFIGUREVARS += "apr_cv_mutex_recursive=yes" to sources/openembedded-core/meta/recipes-support/apr/apr_1.4.6.bb
>> to fix this issue. It has also been removed the mention of this variable in
>> meta/site/powerpc32-linux.
>> 
>> Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
>> ---
>>  meta/recipes-support/apr/apr_1.4.6.bb |    3 +++
>>  meta/site/powerpc32-linux             |    1 -
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>> 
> This really should be 2 patches, I know it was mentioned that you should make the change at the same time.  But it should be done in seperate patches since they actually accomplishing different things.

You don't want two patches here since logically you are moving the define from global space to recipe space.
its aimed at same things.

> 
> Also, the summary title of the commit should be in the format of:
> 
> recipe or file: <Summary>
> 
> So in your case:
> 
> apr: add apr_cv_mutex_recursive=yes to support meta-ros
> 
> <full commit messaage>
> 
> powerpc32-linux: remove apr_cv_mutex_recurisve
> 
> ...
> 
> 
> Thanks
> 	Sau!
> 
>> diff --git a/meta/recipes-support/apr/apr_1.4.6.bb b/meta/recipes-support/apr/apr_1.4.6.bb
>> index 896f79f..ba59639 100644
>> --- a/meta/recipes-support/apr/apr_1.4.6.bb
>> +++ b/meta/recipes-support/apr/apr_1.4.6.bb
>> @@ -23,6 +23,9 @@ inherit autotools lib_package binconfig multilib_header
>> 
>>  OE_BINCONFIG_EXTRA_MANGLE = " -e 's:location=source:location=installed:'"
>> 
>> +# Added to fix some issues with cmake. Refer to https://github.com/bmwcarit/meta-ros/issues/68#issuecomment-19896928
>> +CACHED_CONFIGUREVARS += "apr_cv_mutex_recursive=yes"
>> +
>>  do_configure_prepend() {
>>  	cd ${S}
>>  	./buildconf
>> diff --git a/meta/site/powerpc32-linux b/meta/site/powerpc32-linux
>> index 4550df3..b3973c9 100644
>> --- a/meta/site/powerpc32-linux
>> +++ b/meta/site/powerpc32-linux
>> @@ -203,7 +203,6 @@ apr_cv_use_lfs64=${apr_cv_use_lfs64=yes}
>>  apr_cv_epoll=${apr_cv_epoll=yes}
>>  apr_cv_pthreads_cflags=${apr_cv_pthreads_cflags=-pthread}
>>  apr_cv_pthreads_lib=${apr_cv_pthreads_lib=-lpthread}
>> -apr_cv_mutex_recursive=${apr_cv_mutex_recursive=yes}
>>  ac_cv_func_mmap=${ac_cv_func_mmap=yes}
>>  ac_cv_file__dev_zero=${ac_cv_file__dev_zero=yes}
>>  ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core