Re: [OE-core] [PATCH v3 1/2] ell: add ptests

[Ross Burton <Ross.Burton@arm.com>]

On 1 Aug 2024, at 09:22, Martin Hundeb?ll via lists.openembedded.org <martin=geanix.com@lists.openembedded.org> wrote:
> diff --git a/meta/recipes-core/ell/ell_0.67.bb b/meta/recipes-core/ell/ell_0.67.bb
> index 6b0ebbe62113..ee9aa73d2908 100644
> --- a/meta/recipes-core/ell/ell_0.67.bb
> +++ b/meta/recipes-core/ell/ell_0.67.bb
> @@ -10,9 +10,27 @@ SECTION = "libs"
> LICENSE  = "LGPL-2.1-only"
> LIC_FILES_CHKSUM = "file://COPYING;md5=fb504b67c50331fc78734fed90fb0e09"
> 
> -DEPENDS = "dbus"
> +DEPENDS = "dbus openssl-native xxd-native"

This should be conditional on ptest, right?

> +EXTRA_OECONF += "--enable-tests --enable-maintainer-mode"

Make this conditional on ptest too?

> +do_compile:prepend() {
> +    mkdir -p ${B}/unit
> +}

This sounds like a broken Makefile.am that has a bad assumption in.

> +do_install_ptest() {
> +    install -m755 -Dt ${D}${PTEST_PATH} $(find ${B}/unit -executable -type f)
> +    install -Dt ${D}${PTEST_PATH}/unit \
> +        ${S}/unit/dbus.conf \
> +        ${S}/unit/settings.test \
> +        $(find ${B}/unit -name \*.pem -type f)
> +}

As the test scripts are built with libtool, it’s best to use libtool —mode=install to install them.

Ross