From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by mail.openembedded.org (Postfix) with ESMTP id 800B06A9A1 for ; Tue, 11 Jun 2013 22:36:38 +0000 (UTC) Received: by mail-pa0-f43.google.com with SMTP id hz11so5145671pad.30 for ; Tue, 11 Jun 2013 15:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=DBlFDaeK1x8n4cq6elp28Y7FZRX2dm2pio6IeaPCWH4=; b=nRq0WQnU9dea2frQHvmHyMyLbMlEPL2J4INTz2lqtAwy0+tjrbjt5Lr04XSWqE9NtT h9XZwKwopqPwHcXArNM3ckYGbnTpMlhCQYwzB8mQoNOWSnaLBEA0Wh5EXefgHZkCnsCy /dc6wDNA9iSiMDDt0QEgQszpu87rPD+2bPpUMDr5EEKZ5H0LMj5Yh69pPRKp/nbgRV7o +D1VKBjRzq6XFyfknnKn9WovyKXC8IBqleLhef/0pmBhsca1Bekrg1OGHCpz8IBkgoWs e5kdp63+C37ApAjno+aejgdOlarwR3CyKGnuUpFr9PXn6PoF4qA3ra8RC5jSxf9kC2Ue s+hw== X-Received: by 10.68.226.5 with SMTP id ro5mr17121187pbc.36.1370990199482; Tue, 11 Jun 2013 15:36:39 -0700 (PDT) Received: from sa-nc-common3-188.static.jnpr.net (natint3.juniper.net. [66.129.224.36]) by mx.google.com with ESMTPSA id 6sm16268934pbn.45.2013.06.11.15.36.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 11 Jun 2013 15:36:37 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) From: Khem Raj In-Reply-To: <20130611223524.GM3233@jama> Date: Tue, 11 Jun 2013 15:36:34 -0700 Message-Id: References: <1370987869-19041-1-git-send-email-raj.khem@gmail.com> <1370989876-20531-1-git-send-email-Martin.Jansa@gmail.com> <20130611223524.GM3233@jama> To: Martin Jansa X-Mailer: Apple Mail (2.1508) Cc: openembedded-core@lists.openembedded.org Subject: Re: [RFC][PATCH] gcc-4.8: Backport fix for ICE triggered in pixman X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jun 2013 22:36:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable On Jun 11, 2013, at 3:35 PM, Martin Jansa = wrote: > On Wed, Jun 12, 2013 at 12:31:16AM +0200, Martin Jansa wrote: >> * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D57329 >=20 > Only RFC, because world build is still running to confirm that it > doesn't introduce new issues and that it indeed fixes pixman build for > xscalete. >=20 yes I would love more testing. For my own testing on all qemus it did = not make anything worse than it was with 4.8.0 >>=20 >> Signed-off-by: Martin Jansa >> --- >> meta/recipes-devtools/gcc/gcc-4.8.inc | 1 + >> .../gcc/gcc-4.8/0036-PR-target-56102.patch | 83 = ++++++++++++++++++++++ >> 2 files changed, 84 insertions(+) >> create mode 100644 = meta/recipes-devtools/gcc/gcc-4.8/0036-PR-target-56102.patch >>=20 >> diff --git a/meta/recipes-devtools/gcc/gcc-4.8.inc = b/meta/recipes-devtools/gcc/gcc-4.8.inc >> index 6664f1c..bfdb766 100644 >> --- a/meta/recipes-devtools/gcc/gcc-4.8.inc >> +++ b/meta/recipes-devtools/gcc/gcc-4.8.inc >> @@ -65,6 +65,7 @@ SRC_URI =3D = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \ >> = file://0033-gcc-armv4-pass-fix-v4bx-to-linker-to-support-EABI.patch \ >> = file://0034-Use-the-multilib-config-files-from-B-instead-of-usin.patch \ >> file://0035-wcast-qual-PR-55383.patch \ >> + file://0036-PR-target-56102.patch \ >> file://gcc-4.8-PR56797.patch \ >> file://gcc-4.8-build-args.patch \ >> " >> diff --git = a/meta/recipes-devtools/gcc/gcc-4.8/0036-PR-target-56102.patch = b/meta/recipes-devtools/gcc/gcc-4.8/0036-PR-target-56102.patch >> new file mode 100644 >> index 0000000..a9498fc >> --- /dev/null >> +++ b/meta/recipes-devtools/gcc/gcc-4.8/0036-PR-target-56102.patch >> @@ -0,0 +1,83 @@ >> +=46rom fa049b3584a1cc36c250205e3d5841e6a40ff677 Mon Sep 17 00:00:00 = 2001 >> +From: amker >> +Date: Wed, 27 Mar 2013 08:16:54 +0000 >> +Subject: [PATCH] PR target/56102 >> + >> +* config/arm/arm.c (thumb1_rtx_costs, thumb1_size_rtx_costs): Fix = rtx costs for SET/ASHIFT/ASHIFTRT/LSHIFTRT/ROTATERT patterns with = mult-word mode. >> + >> +git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@197155 = 138bc75d-0d04-0410-961f-82ee72b054a4 >> + >> +Upstream-Status: Backport >> +http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D57329 >> + >> +Signed-off-by: Martin Jansa >> +--- >> + gcc/config/arm/arm.c | 17 ++++++++++++++--- >> + 1 file changed, 14 insertions(+), 3 deletions(-) >> + >> +diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c >> +index 460d333..edf850d 100644 >> +--- a/gcc/config/arm/arm.c >> ++++ b/gcc/config/arm/arm.c >> +@@ -7094,7 +7094,7 @@ static inline int >> + thumb1_rtx_costs (rtx x, enum rtx_code code, enum rtx_code outer) >> + { >> + enum machine_mode mode =3D GET_MODE (x); >> +- int total; >> ++ int total, words; >> +=20 >> + switch (code) >> + { >> +@@ -7102,6 +7102,8 @@ thumb1_rtx_costs (rtx x, enum rtx_code code, = enum rtx_code outer) >> + case ASHIFTRT: >> + case LSHIFTRT: >> + case ROTATERT: >> ++ return (mode =3D=3D SImode) ? COSTS_N_INSNS (1) : = COSTS_N_INSNS (2); >> ++ >> + case PLUS: >> + case MINUS: >> + case COMPARE: >> +@@ -7125,7 +7127,10 @@ thumb1_rtx_costs (rtx x, enum rtx_code code, = enum rtx_code outer) >> + return COSTS_N_INSNS (1) + 16; >> +=20 >> + case SET: >> +- return (COSTS_N_INSNS (1) >> ++ /* A SET doesn't have a mode, so let's look at the SET_DEST = to get >> ++ the mode. */ >> ++ words =3D ARM_NUM_INTS (GET_MODE_SIZE (GET_MODE (SET_DEST = (x)))); >> ++ return (COSTS_N_INSNS (words) >> + + 4 * ((MEM_P (SET_SRC (x))) >> + + MEM_P (SET_DEST (x)))); >> +=20 >> +@@ -7822,6 +7827,7 @@ static inline int >> + thumb1_size_rtx_costs (rtx x, enum rtx_code code, enum rtx_code = outer) >> + { >> + enum machine_mode mode =3D GET_MODE (x); >> ++ int words; >> +=20 >> + switch (code) >> + { >> +@@ -7829,6 +7835,8 @@ thumb1_size_rtx_costs (rtx x, enum rtx_code = code, enum rtx_code outer) >> + case ASHIFTRT: >> + case LSHIFTRT: >> + case ROTATERT: >> ++ return (mode =3D=3D SImode) ? COSTS_N_INSNS (1) : = COSTS_N_INSNS (2); >> ++ >> + case PLUS: >> + case MINUS: >> + case COMPARE: >> +@@ -7847,7 +7855,10 @@ thumb1_size_rtx_costs (rtx x, enum rtx_code = code, enum rtx_code outer) >> + return COSTS_N_INSNS (1); >> +=20 >> + case SET: >> +- return (COSTS_N_INSNS (1) >> ++ /* A SET doesn't have a mode, so let's look at the SET_DEST = to get >> ++ the mode. */ >> ++ words =3D ARM_NUM_INTS (GET_MODE_SIZE (GET_MODE (SET_DEST = (x)))); >> ++ return (COSTS_N_INSNS (words) >> + + 4 * ((MEM_P (SET_SRC (x))) >> + + MEM_P (SET_DEST (x)))); >> +=20 >> +--=20 >> +1.8.2.1 >> + >> --=20 >> 1.8.2.1 >>=20 >=20 > --=20 > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core