public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Andrej Valek" <andrej.valek@siemens.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] vte: add icu dependency
Date: Wed, 6 May 2020 06:23:47 +0000	[thread overview]
Message-ID: <AM6PR10MB30006B2E2AD20BE11908060892A40@AM6PR10MB3000.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200505211114.2519-1-alex.kanavin@gmail.com>

There was a problem, that libvte was searching for non existing symbols in ICU library after upgrading to version 67. But this is little bit funny, that vte could be build without ICU support https://github.com/GNOME/vte/commit/3ecbb90577582b93f43b184aab1cedd61a9ad86b . So looks like, internal ICU is not full matching with external library, even if the external shouldn't be used.

Cheers,
Andrej
 
-----Original Message-----
From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin
Sent: Tuesday, May 5, 2020 11:11 PM
To: openembedded-core@lists.openembedded.org
Cc: Alexander Kanavin <alex.kanavin@gmail.com>
Subject: [OE-core] [PATCH] vte: add icu dependency

This is new in 0.60, and needs to be added explicitly to cause vte to rebuild properly against icu changes (there will be a QA check to catch such situations).

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
 meta/recipes-support/vte/vte_0.60.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/vte/vte_0.60.2.bb b/meta/recipes-support/vte/vte_0.60.2.bb
index 3891ff8165..a722e152a4 100644
--- a/meta/recipes-support/vte/vte_0.60.2.bb
+++ b/meta/recipes-support/vte/vte_0.60.2.bb
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \
     file://COPYING.LGPL3;md5=b52f2d57d10c4f7ee67a7eb9615d5d24 \  "
 
-DEPENDS = "glib-2.0 gtk+3 libpcre2 libxml2-native gperf-native"
+DEPENDS = "glib-2.0 gtk+3 libpcre2 libxml2-native gperf-native icu"
 
 GNOMEBASEBUILDCLASS = "meson"
 GIR_MESON_OPTION = 'gir'
--
2.26.1


      reply	other threads:[~2020-05-06  6:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 21:11 [PATCH] vte: add icu dependency Alexander Kanavin
2020-05-06  6:23 ` Andrej Valek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR10MB30006B2E2AD20BE11908060892A40@AM6PR10MB3000.EURPRD10.PROD.OUTLOOK.COM \
    --to=andrej.valek@siemens.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox