Re: [PATCH] pixz: Add 1.0.6

[Khem Raj <raj.khem@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2940 bytes --]


> On Jan 11, 2016, at 2:36 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> 
> On Mon, 11 Jan 2016 13:17:14 Khem Raj wrote:
>>> On Jan 11, 2016, at 1:07 PM, Paul Eggleton <paul.eggleton@linux.intel.com>
>>> wrote:>
>>> On Mon, 11 Jan 2016 09:36:36 Paul Eggleton wrote:
>>>> On Mon, 11 Jan 2016 09:26:39 Paul Eggleton wrote:
>>>>> On Fri, 08 Jan 2016 18:22:49 Richard Purdie wrote:
>>>>>> xz gives better compression results than bzip/gz but is often slower.
>>>>>> Using parallel compression mitigates this somewhat and is particularly
>>>>>> useful for the SDK.
>>>>>> 
>>>>>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>>>>> 
>>>>>> diff --git a/meta/recipes-support/pixz/pixz_1.0.6.bb
>>>>>> b/meta/recipes-support/pixz/pixz_1.0.6.bb new file mode 100644
>>>>>> index 0000000..e6e4ac2
>>>>>> --- /dev/null
>>>>>> +++ b/meta/recipes-support/pixz/pixz_1.0.6.bb
>>>>>> @@ -0,0 +1,14 @@
>>>>>> +SUMMARY = "Parallel, indexed xz compressor"
>>>>>> +
>>>>>> +DEPENDS = "xz libarchive"
>>>>>> +
>>>>>> +SRC_URI =
>>>>>> "https://github.com/vasi/pixz/releases/download/v${PV}/${BPN}-${PV}.tar
>>>>>> .
>>>>>> xz
>>>>>> "
>>>>> 
>>>>> Can we rely on this never changing? I thought we'd experienced problems
>>>>> with github's release tarballs being generated on the fly in the past...
>>>> 
>>>> Another thing, this seems to fail to build without asciidoc:
>>>> 
>>>> ------------ snip ------------
>>>> checking for src/pixz.1... no
>>>> checking for a2x... no
>>>> configure: error: AsciiDoc not found, not able to generate the man page.
>>>> ------------ snip ------------
>>>> 
>>>> This is also related to not supporting B != S, since src/pixz.1 does
>>>> exist,
>>>> just in S and not B. If you inherit autotools-brokensep instead of
>>>> autotools it works.
>>> 
>>> Possibly a bit obvious, but even inheriting autotools-brokensep isn't
>>> enough, because if it runs "make clean" on re-executing do_configure,
>>> src/pixz.1 gets deleted and you get the same issue.
>> 
>> Adding --without-manpage might get you past this issue.
> 
> I'm afraid that's not a valid option for this configure script.

I was checking the source code on github and now I tried it locally.
the option does exist

git clone https://github.com/vasi/pixz.git
cd pixz
/configure

and it complains

configure: error: AsciiDoc not found, not able to generate the man page.


./configure --without-manpage

succeeds.


> 
> I had more shenanigans trying to build the target version. In the end I needed
> to add "ac_cv_file_src_pixz_1=yes" to EXTRA_OECONF and inherit pkgconfig.
> 

it should be set to ‘no’ if manpages were to be disabled. so I wonder setting it to yes
is just bypassing the configure time check but should fail at compile/install time.

> Cheers,
> Paul
> 
> --
> 
> Paul Eggleton
> Intel Open Source Technology Centre


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]