public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Ross Burton <Ross.Burton@arm.com>
To: "levi.shafter@elder-tomes.com" <levi.shafter@elder-tomes.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] image_types.bbclass: make fsck optional
Date: Fri, 9 Jan 2026 17:03:03 +0000	[thread overview]
Message-ID: <C7184CF3-DBB2-4AE3-AACF-875B74E60632@arm.com> (raw)
In-Reply-To: <585429b3-5763-4c61-97ae-2c73266c887d@elder-tomes.com>

On 31 Dec 2025, at 22:52, Levi Shafter via lists.openembedded.org <levi.shafter=elder-tomes.com@lists.openembedded.org> wrote:
> 
> The fsck in oe_mkext234fs() was added to prevent an extra reboot on the
> target:
> 
> https://git.openembedded.org/openembedded-core/commit/?id=a93d0059341
> 
> This has the side effect of increasing delta between images which
> prevents reproducibility. In many cases, the added security provided by
> image reproducibility is worth the extra reboot upon first booting the
> target. The use of fsck should be included by default, but left
> configurable.
> 
> [YOCTO #16110]

There’s slightly more information in the bug report than here, which links to a video from YPS 2024.12 talking about how fsck will modify timestamps in file systems, so whilst the initial ext4 from mkfs is reproducible, we do a fsck to clear flags and they’re no longer bit-identical.  Is this the only source of non-determinism that you’re observing?

I don’t think adding an option is the right thing here as you’re swapping one problem (non-reproducible ext4) with another (filesystem dirty, needs a reboot).  As the video shows, we should be passing timestamp information at construction time to avoid this problem. Would you be able to work on a patch to do that instead?

Thanks,
Ross

  reply	other threads:[~2026-01-09 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-31 22:52 [PATCH] image_types.bbclass: make fsck optional Levi Shafter
2026-01-09 17:03 ` Ross Burton [this message]
2026-01-12 17:56   ` [OE-core] " Levi Shafter
2026-01-12 21:06   ` Levi Shafter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C7184CF3-DBB2-4AE3-AACF-875B74E60632@arm.com \
    --to=ross.burton@arm.com \
    --cc=levi.shafter@elder-tomes.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox