From: Ross Burton <Ross.Burton@arm.com>
To: "careers.myinfo@gmail.com" <careers.myinfo@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core][master][PATCH] libpcre2: Enabling Ptest support
Date: Mon, 26 Jan 2026 12:44:57 +0000 [thread overview]
Message-ID: <C8CE113D-D026-4EB4-BCB8-CB32EE359E6E@arm.com> (raw)
In-Reply-To: <20260120073923.508721-1-moins@kpit.com>
On 20 Jan 2026, at 07:39, Shaik Moin via lists.openembedded.org <careers.myinfo=gmail.com@lists.openembedded.org> wrote:
> +echo "START: ptest-runner"
> +date +"%Y-%m-%dT%H:%M"
> +echo "BEGIN: $(pwd)"
This isn’t ptest-runner, this is libpcre. You can drop these lines.
> +if [ -n "$results" ]; then
> + printf "%b\n" "$results"
> +fi
This has already been printed, not sure I see the value of printing it again.
> +do_install_ptest() {
> + t=${D}${PTEST_PATH}
> + cp -r ${S}/testdata $t
> + for i in pcre2posix_test pcre2grep pcre2test; \
> + do cp ${B}/.libs/$i $t; \
This assumes that libtool is putting temporary files in specific location. Instead, use libtool to install libtool-built binaries:
${B}/libtool —mode=install install ${B}/$i $t
> + # Skip the fr_FR locale test. If the locale fr_FR is found, it is tested.
> + # If not found, the test is skipped. The test program assumes fr_FR is non-UTF-8
> + # locale so the test fails if fr_FR is UTF-8 locale.
> + sed -i -e 's:do3=yes:do3=no:g' ${D}${PTEST_PATH}/RunTest
Probably worth filing an upstream bug about that assumption.
Ross
next prev parent reply other threads:[~2026-01-26 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 7:39 [OE-core][master][PATCH] libpcre2: Enabling Ptest support Shaik Moin
2026-01-26 12:44 ` Ross Burton [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-11 8:01 Shaik Moin
2026-03-16 4:43 ` Shaik Moin
2026-03-16 7:01 ` Mathieu Dubois-Briand
2026-03-16 7:21 ` Yoann Congal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8CE113D-D026-4EB4-BCB8-CB32EE359E6E@arm.com \
--to=ross.burton@arm.com \
--cc=careers.myinfo@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox