From: Ross Burton <Ross.Burton@arm.com>
To: "Petr Kubizňák - 2N" <kubiznak@2n.com>
Cc: "Martin.Jansa@gmail.com" <Martin.Jansa@gmail.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
Alexander Kanavin <alex.kanavin@gmail.com>
Subject: Re: [OE-core][PATCH v5 1/6] gobject-introspection: reduce dependencies
Date: Mon, 15 May 2023 16:43:33 +0000 [thread overview]
Message-ID: <CB960AF5-CAA9-402B-81EB-01C55B1C0BD0@arm.com> (raw)
In-Reply-To: <DB4PR02MB100309C46E213B4BD625C20C2E2789@DB4PR02MB10030.eurprd02.prod.outlook.com>
> On 15 May 2023, at 15:49, Petr Kubizňák - 2N <kubiznak@2n.com> wrote:
> The key question is whether the problematic packages have intrinsic dependency on g-i-native, which can (and should) be fixed by adding the package in DEPENDS directly, or g-i-native is always needed as Ross says, which would imply g-i-native should not be conditioned by GI_DATA_ENABLED in the class.
>
> I'm not an expert on g-i so I didn't have strong arguments but feel free to convince Alex that g-i-native should be always in DEPENDS.
If we grab a package from git that has a empty m4/ and it has optional support for G-I then it needs a dependency on gobject-introspection-native so that it has introspection.m4 available.
We already inherit gobject-introspection.bbclass, so the dependency can be there. I don’t see why g-i.bbclass would only pull in fundamental build dependencies when it’s enabled.
Ross
next prev parent reply other threads:[~2023-05-15 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 11:06 [OE-core][PATCH v5 1/6] gobject-introspection: reduce dependencies Petr Kubizňák
2023-04-03 11:06 ` [OE-core][PATCH v5 2/6] graphene: add gobject-types PACKAGECONFIG Petr Kubizňák
2023-04-03 11:06 ` [OE-core][PATCH v5 3/6] python3-pygobject: depend on gobject-introspection Petr Kubizňák
2023-04-03 11:06 ` [OE-core][PATCH v5 4/6] gconf: add missing dependencies Petr Kubizňák
2023-04-03 11:06 ` [OE-core][PATCH v5 5/6] webkitgtk: " Petr Kubizňák
2023-04-03 11:06 ` [OE-core][PATCH v5 6/6] libnotify: depend on glib-2.0-native Petr Kubizňák
2023-05-15 11:40 ` [OE-core][PATCH v5 1/6] gobject-introspection: reduce dependencies Martin Jansa
2023-05-15 13:58 ` Ross Burton
2023-05-15 14:49 ` Petr Kubizňák - 2N
2023-05-15 16:43 ` Ross Burton [this message]
2023-05-16 8:21 ` Alexander Kanavin
2023-05-15 15:40 ` Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB960AF5-CAA9-402B-81EB-01C55B1C0BD0@arm.com \
--to=ross.burton@arm.com \
--cc=Martin.Jansa@gmail.com \
--cc=alex.kanavin@gmail.com \
--cc=kubiznak@2n.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox