From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by mail.openembedded.org (Postfix) with ESMTP id E70CA60796 for ; Wed, 2 Nov 2016 17:22:06 +0000 (UTC) Received: by mail-pf0-f194.google.com with SMTP id y68so2286814pfb.1 for ; Wed, 02 Nov 2016 10:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=AIpnPygPeoj+wnHHAYXvVzHfFWOIe54U2qZnjFcioVU=; b=bG9XE7alok+bkowB8y9BezdOKlLb619ymk5iRLCYYkXzZCWDrfZAqahRW6XfK9ihLE IZDKvUlIDKrf/xIH4apH6Aw08Abxfhkgp4YmaeE9TywUhve6H6Wai04r/v2J+QhU3LG9 gQcbi0qOTUWqXEpe/1Ea835fXtkytINIrAEzu6OCXhbRM/yYQb/iFYialAZIgQ7kSKm9 HStdJ9/AnKKX8NPZTVv8+FdxaKl76423SIUj/tAOuM+Z2q2qQG9Dqr9HSq0WuEX4Uq+K PyGkh/7vfwoxOTa9tzc3yoPIpsAN1o2QL95onAVDmiXoiuguR72FyoWUquer0z16uGrd jUCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=AIpnPygPeoj+wnHHAYXvVzHfFWOIe54U2qZnjFcioVU=; b=KLBGReYG/LIUgA/XODb9PbQPbaKf8vGNdUVtO9jShv40+MAoOYukTeaucrrBheOibL x/VfCUnE6oCSl7ob16BaAA16MQfULDsXI3CJIlUsQZE8ysEhc/87+LHcJVCnvHvGFkFR I6ZuF/uKRnLc8iNPsjmbuSGYLUF0mpKv2/Wx88m0kG6d6wEWwHvxHrBpyuK4l02lyZou G/uneZaSWZDCyKPLcZmgDQtzIigguNrccSv5vMWxxD5OF9QOvC7+tK2HWRYOCThTa28N QI/p+1q2mbxBkpyFWfdXcuHQT/lGP6Rxsf/9GP/ydiM8aBiXScFshyRWIMfECspsxu4A h7ZA== X-Gm-Message-State: ABUngvevpmtjMkgLfXt4ZeH4UibPGWhlfrlwVbqteu7DAa452j996mH8UCpUlwpQLCtgUg== X-Received: by 10.98.70.150 with SMTP id o22mr8851332pfi.134.1478107327950; Wed, 02 Nov 2016 10:22:07 -0700 (PDT) Received: from ?IPv6:2601:646:8882:b8c:9d22:31df:3be1:5792? ([2601:646:8882:b8c:9d22:31df:3be1:5792]) by smtp.gmail.com with ESMTPSA id ak3sm6187028pad.19.2016.11.02.10.22.07 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Nov 2016 10:22:07 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Pgp-Agent: GPGMail From: Khem Raj In-Reply-To: Date: Wed, 2 Nov 2016 10:22:01 -0700 Message-Id: References: To: "Burton, Ross" X-Mailer: Apple Mail (2.3124) Cc: OE-core Subject: Re: [PATCH 09/13] icu: update to 58.1 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 17:22:09 -0000 X-Groupsio-MsgNum: 88927 Content-Type: multipart/signed; boundary="Apple-Mail=_E81784C3-DE56-48C5-B209-A8B1E39E1ED6"; protocol="application/pgp-signature"; micalg=pgp-sha1 --Apple-Mail=_E81784C3-DE56-48C5-B209-A8B1E39E1ED6 Content-Type: multipart/alternative; boundary="Apple-Mail=_FC447465-8396-477D-A727-D047D56F8FFA" --Apple-Mail=_FC447465-8396-477D-A727-D047D56F8FFA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Nov 2, 2016, at 5:16 AM, Burton, Ross = wrote: >=20 >=20 > On 1 November 2016 at 15:25, Alexander Kanavin = > wrote: > The copyright for the software has been transferred to Unicode Inc = from IBM, > but the terms are same. >=20 > libiculx and libicule are no longer produced as they depend on an = external > package icu-le-hb (previous versions had an option of using an = internal > implementation which now has been dropped). I have verified that icu > dependencies in oe-core and meta-oe still build. >=20 > Signed-off-by: Alexander Kanavin > >=20 > This breaks under musl: >=20 > ../../icu/source/i18n/digitlst.cpp:67:24: fatal error: xlocale.h: No = such file or directory > # include >=20 > musl doesn't have xlocale.h but does have a crippled strtod_l (doesn't = actually support a passed in locale, which is the entire point of the _l = functions). >=20 > Upstreams such as pulseaudio have done = https://bugs.freedesktop.org/attachment.cgi?id=3D118644 = to guard the = include, but I see that digitlist.cpp has an alternative branch where = strtod_l isn't supported: as that function on musl is crippled maybe ICU = should be told not to use it? the _l functions were added as aliases for ABI compatibility reasons, = however, it should work well and is compatible with glibc versions. = however its not defined that it should only come from xlocale.h so we should check for xlocale.h to = be present on rootfs before using it. >=20 > Ross > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core --Apple-Mail=_FC447465-8396-477D-A727-D047D56F8FFA Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On Nov 2, 2016, at 5:16 AM, Burton, Ross <ross.burton@intel.com> wrote:


On 1 November 2016 at 15:25, Alexander Kanavin = <alexander.kanavin@linux.intel.com> wrote:
The copyright for the software has = been transferred to Unicode Inc from IBM,
but the terms are same.

libiculx and libicule are no longer produced as they depend on an = external
package icu-le-hb (previous versions had = an option of using an internal
implementation which now has been dropped). I have verified that icu
dependencies in oe-core and meta-oe still build.

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>

This = breaks under musl:

../../icu/source/i18n/digitlst.cpp:67:24: fatal error: = xlocale.h: No such file or directory
 #   = include <xlocale.h>

musl doesn't have xlocale.h but does have a crippled strtod_l = (doesn't actually support a passed in locale, which is the entire point = of the _l functions).

Upstreams such as pulseaudio have done https://bugs.freedesktop.org/attachment.cgi?id=3D118644 = to guard the include, but I see that digitlist.cpp has an alternative = branch where strtod_l isn't supported: as that function on musl is = crippled maybe ICU should be told not to use = it?

the _l = functions were added as aliases for ABI compatibility reasons, however, = it should work well and is compatible with glibc versions. however its = not defined that
it should only come from xlocale.h so we = should check for xlocale.h to be present on rootfs before using = it.


Ross
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-cor= e

= --Apple-Mail=_FC447465-8396-477D-A727-D047D56F8FFA-- --Apple-Mail=_E81784C3-DE56-48C5-B209-A8B1E39E1ED6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iEYEARECAAYFAlgaIL4ACgkQuwUzVZGdMxSixACfTxLjjIrJvTehzAI6a07RlKfA AfwAoIqLLPiSXBVTtPIasMCO3EoBnk0M =7tb9 -----END PGP SIGNATURE----- --Apple-Mail=_E81784C3-DE56-48C5-B209-A8B1E39E1ED6--