Re: [PATCH 0/4] Add gummiboot boot manager alongside grub-efi

[Darren Hart <dvhart@linux.intel.com>]

On 3/9/14, 9:04, "Stefan Stanacar" <stefanx.stanacar@intel.com> wrote:

>Hello,
>
>This series adds recipes for gummiboot and a class allowing it to be used
>as the boot loader for live/hddimg images.
>Without changing EFI_PROVIDER, we have the same behaviour for EFI
>machines.
>Using EFI_PROVIDER = "gummiboot" an installed image will use gummiboot
>instead
>of grub-efi as it's boot manager.
>
>I've tested this on FRI2, NUC and minnow (live USB boot and install from
>USB and boot) 
>with  EFI_PROVIDER = "gummiboot" and  KERNEL_FEATURES_append = "
>cfg/efi-ext"
>in local.conf
>
>This is a partial fix for YB#4082.
>
>Changes in V2:
> - split the first patch in two
> - used ${B} instead of ${S} in gummiboot do_deploy
> - change the function names in bootimg/grub-efi instead of using a
>prefix
>
>I've tested again the changes on top of master.

This series looks much improved to me. I think it can go in as it stands.

Acked-by: Darren Hart <dvhart@linux.intel.com>

One thing I would like to see improved it the definition of the efi class
interface. I don't know how we do something like an abstract base class in
bb-speak, but someone wanting to add another EFI class needs to be able to
learn what the required methods and arguments are. Also, efi_populate()
isn't one of those interfaces, and that should probably not use the
generic efi_ prefix as it is effectively a gummiboot or grub-efi private
method, and should be named accordingly.

But, those are nitpics that can be cleaned up over time as we polish and
extend this mechanism. Time to get this in and get some broader
use/testing.

Ultimately, I'd like to see gummiboot as the default, but I can also just
set that in meta-intel if others do not agree.

Thank you for you efforts here Stefan!

-- 
Darren Hart
Yocto Project - Linux Kernel
Intel Open Source Technology Center