From: Markus Lehtonen <markus.lehtonen@linux.intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] scripts: introduce buildstats-diff
Date: Thu, 15 Sep 2016 09:38:31 +0300 [thread overview]
Message-ID: <D4001C1A.67CC9%markus.lehtonen@linux.intel.com> (raw)
In-Reply-To: <CAJTo0LYuNzYTdhjmgpf-9rEC-axKW-khVGzU6iPN+MC=i+8arQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
From: "Burton, Ross" <ross.burton@intel.com>
Date: Wednesday 14 September 2016 at 19:38
To: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] scripts: introduce buildstats-diff
On 14 September 2016 at 12:24, Markus Lehtonen
<markus.lehtonen@linux.intel.com> wrote:
> + if not tasks1:
> + pkg_op = '++'
> + elif not tasks2:
> + pkg_op = '--'
BTW, I've been reading buildstats-diff output all day and find the lack of
whitespace between the operator and the package name makes the output harder
to read, so I've patched it locally to be just '+ ' or '- ' for clarity.
Sounds fine to me. I don't object your modification.
- Markus
[-- Attachment #2: Type: text/html, Size: 2295 bytes --]
prev parent reply other threads:[~2016-09-15 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 11:24 [PATCH] scripts: introduce buildstats-diff Markus Lehtonen
2016-09-14 16:38 ` Burton, Ross
2016-09-15 6:38 ` Markus Lehtonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4001C1A.67CC9%markus.lehtonen@linux.intel.com \
--to=markus.lehtonen@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox