Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Markus Lehtonen <markus.lehtonen@linux.intel.com>
To: Mariano Lopez <mariano.lopez@linux.intel.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/8] oeqa.utils.metadata: drop 'unknown' git data elements
Date: Thu, 05 Jan 2017 11:19:03 +0200	[thread overview]
Message-ID: <D493DC27.6E783%markus.lehtonen@linux.intel.com> (raw)
In-Reply-To: <edb7398f-c7f9-8ec4-daf5-c5c350c0d671@linux.intel.com>

On 04/01/2017, 17.30, "Mariano Lopez" <mariano.lopez@linux.intel.com>
wrote:
>On 28/12/16 07:02, Markus Lehtonen wrote:
>> It's better just to not have the xml elements than to have elements with
>> faux data. One could have git branch named 'unknown', for example.
>>
>>
>
>I don't think is a good idea to completely remove the layer from the
>metadata when such layer is not a repository, it would remove valuable
>information for later analysis. And if you ask would do such a thing, I
>would, I have my own debug layers that can mess with testing.

I'm not removing the entire layer. I'm just removing the
<branch>unknown</branch> and <revisio>unknown</revision> elements. So the
layer elements are still there.

Thanks,
   Markus




  reply	other threads:[~2017-01-05  9:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-28 13:02 [PATCH 0/8] oeqa.utils.metadata: update xml schema Markus Lehtonen
2016-12-28 13:02 ` [PATCH 1/8] oeqa.utils.metadata: re-organise host distro information Markus Lehtonen
2016-12-28 13:02 ` [PATCH 2/8] oeqa.utils.metadata: re-organise " Markus Lehtonen
2016-12-28 13:02 ` [PATCH 3/8] oeqa.utils.metadata: drop 'unknown' git data elements Markus Lehtonen
2017-01-04 15:30   ` Mariano Lopez
2017-01-05  9:19     ` Markus Lehtonen [this message]
2016-12-28 13:02 ` [PATCH 4/8] oeqa.utils.metadata: fix retrieval of git branch and revision Markus Lehtonen
2016-12-28 13:02 ` [PATCH 5/8] oeqa.utils.metadata: rename 'revision' to 'commit' Markus Lehtonen
2016-12-28 13:02 ` [PATCH 6/8] oeqa.utils.metadata: add commit count information Markus Lehtonen
2016-12-28 13:02 ` [PATCH 7/8] oeqa.utils.metadata: have layer name as an attribute in xml Markus Lehtonen
2017-01-04 15:43   ` Mariano Lopez
2017-01-05  9:35     ` Markus Lehtonen
2016-12-28 13:02 ` [PATCH 8/8] oeqa.utils.metadata: add bitbake revision information Markus Lehtonen
2017-01-04 15:45   ` Mariano Lopez
2017-01-05  9:40     ` Markus Lehtonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D493DC27.6E783%markus.lehtonen@linux.intel.com \
    --to=markus.lehtonen@linux.intel.com \
    --cc=mariano.lopez@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox