From: Khem Raj <raj.khem@gmail.com>
To: kai.kang@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] Revert "glib-2.0: build dependency cleanup"
Date: Thu, 31 Dec 2015 00:50:20 -0800 [thread overview]
Message-ID: <D6F56C56-75BE-40AD-BDDC-AE6F14263057@gmail.com> (raw)
In-Reply-To: <c46aeee4002b37e3f84433f78cbb82278e5d066e.1451382094.git.kai.kang@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]
> On Dec 29, 2015, at 1:43 AM, kai.kang@windriver.com wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> This reverts commit fcd7494b347423185c883b2897c4908929843a71.
>
> It uses command glib-genmarshal to build glib-2.0 which is from
> glibc-2.0-native. If the command doesn't exist on host, build fails
typo 'glib-2.0-native'
> with error:
>
> | /bin/sh: --prefix=test_marshal: command not found
> | make[4]: *** [testmarshal.c] Error 127
>
> So add the dependency back.
I ran into the regression as well. So this patch is good.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
> meta/recipes-core/glib-2.0/glib.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 86f7e0e..8e4dcd7 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -17,10 +17,10 @@ SECTION = "libs"
>
> BBCLASSEXTEND = "native nativesdk"
>
> -DEPENDS = "virtual/libiconv libffi zlib"
> -DEPENDS_append = " ${@bb.utils.contains('PTEST_ENABLED', '1', ' glib-2.0-native dbus', '', d)}"
> +DEPENDS = "glib-2.0-native virtual/libiconv libffi zlib"
> +DEPENDS_append_class-target = "${@bb.utils.contains('DISTRO_FEATURES', 'ptest', ' dbus', '', d)}"
> DEPENDS_class-native = "pkgconfig-native gettext-native libffi-native zlib-native"
> -DEPENDS_class-nativesdk = "nativesdk-libtool nativesdk-gettext nativesdk-libffi nativesdk-zlib"
> +DEPENDS_class-nativesdk = "nativesdk-libtool nativesdk-gettext nativesdk-libffi nativesdk-zlib ${BPN}-native"
>
> PACKAGES =+ "${PN}-utils ${PN}-bash-completion ${PN}-codegen"
>
> --
> 2.6.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
next prev parent reply other threads:[~2015-12-31 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 9:43 [PATCH 0/1] Add dependency back for glib-2.0 kai.kang
2015-12-29 9:43 ` [PATCH 1/1] Revert "glib-2.0: build dependency cleanup" kai.kang
2015-12-31 8:50 ` Khem Raj [this message]
2016-01-04 2:09 ` Kang Kai
2016-01-04 10:47 ` Burton, Ross
2016-01-06 2:33 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6F56C56-75BE-40AD-BDDC-AE6F14263057@gmail.com \
--to=raj.khem@gmail.com \
--cc=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox