From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Richard Purdie" <richard.purdie@linuxfoundation.org>,
<yocto-patches@lists.yoctoproject.org>,
"Enrico Scholz" <enrico.scholz@sigma-chemnitz.de>,
"Scott Murray" <scott.murray@konsulko.com>
Cc: <openembedded-core@lists.openembedded.org>
Subject: Re: [yocto-patches] [meta-lts-mixins][scarthgap/rust][PATCH] classes: rename to classes-recipes/
Date: Wed, 22 Jan 2025 09:10:19 +0100 [thread overview]
Message-ID: <D78G6XLG1PEU.I9ZF3M0NFRU2@bootlin.com> (raw)
In-Reply-To: <648e69b6898d3f95bea785d1ee56e2ce500ae579.camel@linuxfoundation.org>
Hi all,
On Mon Jan 20, 2025 at 11:54 PM CET, Richard Purdie wrote:
> On Mon, 2025-01-20 at 16:32 -0500, Scott Murray via lists.yoctoproject.org wrote:
>> On Mon, 20 Jan 2025, Enrico Scholz wrote:
>>
>> > Scott Murray <scott.murray@konsulko.com> writes:
>> >
>> > > > bitbake looks first in 'classes-recipes/' and then in
>> > > > 'classes/'.
>> > > > Hence, content had no effect and was just ignored.
>> > > >
>> > > > Rename folder so that it overrides the OE-core classes.
>> > > >
>> > > > Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
>> > > [snip]
>> > >
>> > > I'm pretty sure this is incorrect.
>> >
>> > Logic is in [1]
>> >
>> > --> first iterate (using $BBPATH) in 'recipes-%', then in 'recipes'
>>
>> Hmm, the code I looked at was in lib/bblayers/query.py, and its logic is
>> different AFAICT. Can you confirm that "bitbake-layers show-overlayed"
>> shows it as being overlayed for you as it does for me? That it does
>> would seem to indicate a bblayers bug, and there is perhaps some missing
>> documentation of this behavior (change) (e.g. I don't see any mention of
>> classes-global vs classes-recipe vs classes and how their prioritization
>> works wrt layers in the docs). I'm CC'ing oe-core just in case I'm
>> really missing something here...
>
> I think bblayers needs fixing and we need to sort the docs too...
>
> Copying Antonin as we probably want a bug to track that.
I've created a bug to track this:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15724
Scott, I've assigned you to it, as you proposed to add this yesterday on the
tech meeting. Let me know if you need any help for adding documentation (it
should be part of bitbake/doc most likely).
Also let me know if I got it wrong yesterday and if I should re-assign this.
Thank you,
Antonin
--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-01-22 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250120165117.737681-1-enrico.scholz@sigma-chemnitz.de>
[not found] ` <1f6cdeb4-c868-e32c-4372-123371eb4b12@konsulko.com>
[not found] ` <lybjw1ffw0.fsf@ensc-pc.intern.sigma-chemnitz.de>
2025-01-20 21:32 ` [meta-lts-mixins][scarthgap/rust][PATCH] classes: rename to classes-recipes/ Scott Murray
2025-01-20 22:54 ` [yocto-patches] " Richard Purdie
2025-01-22 8:10 ` Antonin Godard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D78G6XLG1PEU.I9ZF3M0NFRU2@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=scott.murray@konsulko.com \
--cc=yocto-patches@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox