Re: [OE-core] [PATCH 1/2] scripts/install-buildtools: add an option to preserve downloads

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Alex,

On Tue Mar 11, 2025 at 11:41 AM CET, Alexander Kanavin via lists.openembedded.org wrote:
> From: Alexander Kanavin <alex@linutronix.de>
>
> By default the script puts everything it downloads into a temporary
> directory and erases it after unpacking and installing the buildtools.
>
> This isn't great for traceability and reproducibility of builds
> (being able to see what was downloaded exactly, and being able
> to reproduce setting up a build, especially if the buildtools
> download location isn't available for whatever reason).
>
> This commit adds an option to download items into a specified directory
> and keep them there. I would particularly like to use it
> with bitbake-setup, where an optional script to install the buildtools
> would ensure the tarball remains available on local disk.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  scripts/install-buildtools | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/install-buildtools b/scripts/install-buildtools
> index 639ebb12d78..1a68aad53e7 100755
> --- a/scripts/install-buildtools
> +++ b/scripts/install-buildtools
> @@ -142,6 +142,9 @@ def main():
>                          default=DEFAULT_INSTALL_DIR,
>                          help='directory where buildtools SDK will be installed (optional)',
>                          action='store')
> +    parser.add_argument('--keep-downloads-directory',
> +                        help='use this directory for tarball/checksum downloads and do not erase them (default is a temporary directory which is deleted after unpacking and installing the buildtools)',
> +                        action='store')
>      parser.add_argument('-r', '--release',
>                          default=DEFAULT_RELEASE,
>                          help='Yocto Project release string for SDK which will be '
> @@ -235,11 +238,11 @@ def main():
>                  safe_filename = quote(filename)
>                  buildtools_url = "%s/%s/buildtools/%s" % (base_url, args.release, safe_filename)
>  
> -    tmpsdk_dir = tempfile.mkdtemp()
> +    sdk_dir = args.keep_downloads_directory or tempfile.mkdtemp()

How about also creating the directory if args.keep_downloads_directory is set?

Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com