Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <pierre-loup.gosse@smile.fr>, <openembedded-core@lists.openembedded.org>
Cc: "Alexander Kanavin" <alex.kanavin@gmail.com>
Subject: Re: [OE-core] [PATCH v2] wic: add --extra-part-space option to set unused space
Date: Sat, 09 Aug 2025 14:57:08 +0200	[thread overview]
Message-ID: <DBXWWY2ZO45D.363V2QKSL85VW@bootlin.com> (raw)
In-Reply-To: <20250808144958.1005928-1-pierre-loup.gosse@smile.fr>

On Fri Aug 8, 2025 at 4:49 PM CEST, pierre-loup.gosse via lists.openembedded.org wrote:
> From: Pierre-Loup GOSSE <pierre-loup.gosse@smile.fr>
>
> Currently, the content of the partition is filled by the filesystem
> without leaving any unused free space. The --extra-space flag adds
> extra space to the filesystem size, not to the partition.
>
> Unused free space after the filesystem can be useful for some cases,
> such as encrypting a partition at runtime. With --extra-part-space 32M,
> we ensure that the last 32M of the partition is unused: this space does
> not contain filesystem data and can store the LUKS2 header.
>
> The implementation sets a difference between the partition and
> filesystem size:
>   - With --fixed-size, the extra part space is removed from the
>     filesystem size.
>   - Otherwise (with or without --size flags), the extra part space is
>     added to the partition size.
>
> Signed-off-by: Pierre-Loup GOSSE <pierre-loup.gosse@smile.fr>
>
> CC: Alexander Kanavin <alex.kanavin@gmail.com>
> ---

Hi Pierre-Loup,

Thanks for the v2.

It looks like this is failing the selftests:

2025-08-09 08:38:22,672 - oe-selftest - INFO - 9: 75/92 535/635 (30.50s) (2 failed) (wic.Wic2.test_fixed_size_error)
2025-08-09 08:38:22,672 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/lib/oeqa/selftest/cases/wic.py", line 1221, in test_fixed_size_error
    p, _ = self._get_wic_partitions(wkspath, ignore_status=True)
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/lib/oeqa/selftest/cases/wic.py", line 1192, in _get_wic_partitions
    res = runCmd("parted -m %s unit kib p" % wicimg,
                 native_sysroot=native_sysroot, stderr=subprocess.PIPE)
  File "/srv/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/lib/oeqa/utils/commands.py", line 214, in runCmd
    raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
AssertionError: Command 'parted -m None unit kib p' returned non-zero exit status 1:
WARNING: You are not superuser.  Watch out for permissions.
Error: Could not stat device None - No such file or directory.


https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/2050
https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/2121
https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/2271

Can you have a look at this issue please?

Best regards,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2025-08-09 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 14:49 [PATCH v2] wic: add --extra-part-space option to set unused space pierre-loup.gosse
2025-08-09 12:57 ` Mathieu Dubois-Briand [this message]
2025-08-11  8:52 ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBXWWY2ZO45D.363V2QKSL85VW@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pierre-loup.gosse@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox