Re: [OE-core] [PATCH] vulkan-validation-layers: fix compile failure with DEBUG_BUILD = 1

["Antonin Godard" <antonin.godard@bootlin.com>]

On Mon Sep 1, 2025 at 9:39 AM CEST, hongxu via lists.openembedded.org wrote:
> When building with GCC 14+ using -Og (DEBUG_BUILD = 1), got
> the following errors:
>
> $ echo 'DEBUG_BUILD = "1"' >> conf/local.conf
> $ echo 'DISTRO_FEATURES:append = " vulkan opengl"' >> conf/local.conf
> $ bitbake vulkan-validation-layers
> ...
> |TOPDIR/tmp/work/core2-32-wrs-linux/vulkan-validation-layers/1.4.309.0/git/layers/./external/
> xxhash.h:4822:1: error: inlining failed in call to 'always_inline' 'void XXH3_scrambleAcc_sse2
> (void*, const void*)': function not considered for inlining
> ...
>
> Refer [1], using XXH_NO_INLINE_HINTS when compiling with -Og (DEBUG_BUILD = 1)
>
> [1] https://github.com/Cyan4973/xxHash/issues/943
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  .../vulkan/vulkan-validation-layers_1.4.321.0.bb                | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb
> index fa7873b62d3..466e757a908 100644
> --- a/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb
> +++ b/meta/recipes-graphics/vulkan/vulkan-validation-layers_1.4.321.0.bb
> @@ -26,6 +26,8 @@ EXTRA_OECMAKE = "\
>      -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \
>      "
>  
> +CXXFLAGS:append = " ${@oe.utils.vartrue('DEBUG_BUILD', '-DXXH_NO_INLINE_HINTS=1', '', d)}"

Minor optmization: could we use "CXXFLAGS +=" instead of :append here?

Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com