Re: [OE-core] [PATCH 2/4] oeqa: runtime: Ignore SSH errors during setup and tear down

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Thu Oct 9, 2025 at 4:26 PM CEST, Ross Burton via lists.openembedded.org wrote:
> On 7 Oct 2025, at 18:38, Mathieu Dubois-Briand via lists.openembedded.org <mathieu.dubois-briand=bootlin.com@lists.openembedded.org> wrote:
>> 
>> Tests using SSH will fail when no SSH server is present on the target.
>> These tests are disabled in these cases, by being marked with a
>> dependency on ssh.SSHTest.test_ssh, which in turns has a dependency on
>> having either dropbear or openssh-sshd in the image.
>> 
>> But setUpClass() and tearDownClass() functions are always executed, even
>> on tests failing the dependency checks, leading to unexpected failed
>> tests.
>
> Well that’s just silly.  I wonder if OEHasPackage() works on the class scope too and does actually avoid doing the setup/teardown?
>
> However, this does demonstrate that doing non-trivial setup/teardown is a bad idea in test cases, and copying files to the target is definitely non-trivial.
>
> I suggest merging all of the logrotate tests and setup/teardown into a single test that uses finally: to cleanup, and just removing the teardown from the weston test.
>

I am going to send some patches to clean this.

On the logrotate one, I choose to keep two separate tests, but we can
highly simplify this cleanup part and integrate that in the tests. On
weston, let's remove the log file before starting weston, so we can
still be sure the log is clean.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com