public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <dev@g0hl1n.net>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] fitimage: introduce FIT_CONF_STRIP_EXT
Date: Fri, 09 Jan 2026 09:09:04 +0100	[thread overview]
Message-ID: <DFJWLQHKFVV3.3NP73J5UXWC0V@bootlin.com> (raw)
In-Reply-To: <20260107092600.73848-1-dev@g0hl1n.net>

On Wed Jan 7, 2026 at 10:26 AM CET, Richard Leitner via lists.openembedded.org wrote:
> Introduce a configuration variable named FIT_CONF_STRIP_EXT which
> removes the file-type extension from the configuration node name.
>
> This feature enables us to give configuration nodes arbritary names
> (based on the dtb file names). This is in my case needed to ensure
> consistent configuration names which where previously (walnascar)
> generated using a fitimage_emit_section_config:append() function.
>
> Signed-off-by: Richard Leitner <dev@g0hl1n.net>
> ---

Hi Richard,

Thanks for your patch.

It looks like this is making some selftest fail:

2026-01-08 18:18:47,312 - oe-selftest - INFO - fitimage.FitImagePyTests.test_fitimage_py_conf_extra_mappings_unused_error (subunit.RemotedTestCase)
2026-01-08 18:18:47,313 - oe-selftest - INFO -  ... ERROR
...
2026-01-08 18:18:47,313 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 1257, in test_fitimage_py_conf_extra_mappings_unused_error
    self._test_fitimage_py(bb_vars_overrides)
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 1203, in _test_fitimage_py
    root_node.fitimage_emit_section_config(bb_vars['FIT_CONF_DEFAULT_DTB'], bb_vars.get('FIT_CONF_MAPPINGS'))
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oe/fitimage.py", line 498, in fitimage_emit_section_config
    default_conf = self.configurations.sub_nodes[0].name
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

...
2026-01-08 18:18:47,317 - oe-selftest - INFO - fitimage.FitImagePyTests.test_fitimage_py_conf_mappings (subunit.RemotedTestCase)
2026-01-08 18:18:47,317 - oe-selftest - INFO -  ... ERROR
...
2026-01-08 18:18:47,322 - oe-selftest - INFO - fitimage.FitImagePyTests.test_fitimage_py_conf_mappings_unused_error (subunit.RemotedTestCase)
2026-01-08 18:18:47,322 - oe-selftest - INFO -  ... ERROR
...
2026-01-08 18:18:47,327 - oe-selftest - INFO - fitimage.FitImagePyTests.test_fitimage_py_conf_mappings_with_alias (subunit.RemotedTestCase)
2026-01-08 18:18:47,327 - oe-selftest - INFO -  ... ERROR
...
2026-01-08 18:18:47,338 - oe-selftest - INFO - fitimage.FitImagePyTests.test_fitimage_py_default_dtb (subunit.RemotedTestCase)
2026-01-08 18:18:47,339 - oe-selftest - INFO -  ... ERROR

I did not copy all the errors, as they are all similar to the first one.

https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/2989
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/2880
https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/3127

Can you have a look at these issues?

Note, I had merge conflicts on your patch, so maybe my resolution was
incorrect. If that's the case, can you rebase on master before sending
the new version?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2026-01-09  8:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  9:26 [PATCH] fitimage: introduce FIT_CONF_STRIP_EXT Richard Leitner
2026-01-09  8:09 ` Mathieu Dubois-Briand [this message]
2026-01-09  8:28   ` [OE-core] " Richard Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFJWLQHKFVV3.3NP73J5UXWC0V@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=dev@g0hl1n.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox