From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Paul Barker" <paul@pbarker.dev>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] coreutils: Backport fix for lseek_copy loop
Date: Wed, 21 Jan 2026 13:39:19 +0100 [thread overview]
Message-ID: <DFU9V6ZMRPSI.D5A7XD6GPHK4@bootlin.com> (raw)
In-Reply-To: <20260121-fix-coreutils-v1-1-30a1769b5733@pbarker.dev>
Hi,
On Wed Jan 21, 2026 at 11:41 AM CET, Paul Barker wrote:
[...]
> diff --git a/meta/recipes-core/coreutils/coreutils/0001-fix-lseek-copy-loop.patch b/meta/recipes-core/coreutils/coreutils/0001-fix-lseek-copy-loop.patch
> new file mode 100644
> index 000000000000..75286dc43cb9
> --- /dev/null
> +++ b/meta/recipes-core/coreutils/coreutils/0001-fix-lseek-copy-loop.patch
> @@ -0,0 +1,35 @@
> +From bd528f923482223649aa84be7d131e69356149da Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P@draigBrady.com>
> +Date: Sun, 4 Jan 2026 12:45:46 +0000
> +Subject: [PATCH] copy: fix possible infinite loop with SEEK_HOLE
> +
> +Commit v9.8-95-g4c0cf3864 intended to initialize
> +ext_start to src_pos, as was described at:
> +https://lists.gnu.org/r/coreutils/2025-11/msg00035.html
> +However ipos was inadvertently used, which is only
> +valid the first time through the loop.
> +
> +* src/copy-file-data.c (lseek_copy): Use scan_inference->hole_start
> +only with the initial offset passed to lseek_copy().
> +* NEWS: Mention the bug fix.
> +Reported at https://github.com/coreutils/coreutils/issues/159
> +
> +Upstream-Status: Backport (commit bd528f923482223649aa84be7d131e69356149da)
I wonder if having the reason between brackets and not parenthesis is important
here? That's what we document but they could interchangeable, I don't know for
sure.
Antonin
--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-01-21 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 10:41 [PATCH] coreutils: Backport fix for lseek_copy loop Paul Barker
2026-01-21 12:39 ` Antonin Godard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFU9V6ZMRPSI.D5A7XD6GPHK4@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul@pbarker.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox