public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: <ukleinek@baylibre.com>, <openembedded-core@lists.openembedded.org>
Cc: "Joe MacDonald" <joe.macdonald@siemens.com>,
	"Yi Zhao" <yi.zhao@windriver.com>
Subject: Re: [OE-core] [PATCH] busybox: Enable SELinux support if DISTRO_FEATURES contains 'selinux'
Date: Tue, 17 Feb 2026 10:13:24 +0100	[thread overview]
Message-ID: <DGH4E8RFJGEA.R2SUJPB21TR0@smile.fr> (raw)
In-Reply-To: <20260216164527.864396-1-u.kleine-koenig@baylibre.com>

On Mon Feb 16, 2026 at 5:45 PM CET, "Uwe Kleine-König via lists.openembedded.org wrote:
> If selinux is contained in DISTRO_FEATURES, enable CONFIG_SELINUX which
> needs a dependency on libselinux.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> this targets oe-core master, but it would be great if it could be
> backported to scarthgap which is what I'm currently using.

Hello,

Thank you for the patch. However, this is a new feature and would change
behavior for users of BusyBox and SELinux. Therefore, I cannot take this
patch for Scarthgap.

Regards,

>
> Best regards
> Uwe
>
>  meta/recipes-core/busybox/busybox.inc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
> index c85117efc80f..355c01973848 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -4,6 +4,7 @@ HOMEPAGE = "https://www.busybox.net"
>  BUGTRACKER = "https://bugs.busybox.net/"
>  
>  DEPENDS += "kern-tools-native virtual/crypt"
> +DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'libselinux', '', d)}"
>  
>  # bzip2 applet in busybox is based on lightly-modified bzip2-1.0.4 source
>  # the GPL is version 2 only
> @@ -86,6 +87,7 @@ def features_to_busybox_settings(d):
>      busybox_cfg(bb.utils.contains('DISTRO_FEATURES', 'ipv4', True, False, d), 'CONFIG_FEATURE_IFUPDOWN_IPV4', cnf, rem)
>      busybox_cfg(bb.utils.contains('DISTRO_FEATURES', 'ipv6', True, False, d), 'CONFIG_FEATURE_IFUPDOWN_IPV6', cnf, rem)
>      busybox_cfg(bb.utils.contains_any('DISTRO_FEATURES', 'bluetooth wifi', True, False, d), 'CONFIG_RFKILL', cnf, rem)
> +    busybox_cfg(bb.utils.contains('DISTRO_FEATURES', 'selinux', True, False, d), 'CONFIG_SELINUX', cnf, rem)
>      return "\n".join(cnf), "\n".join(rem)
>  
>  # X, Y = ${@features_to_busybox_settings(d)}
>
> base-commit: 2c20c05b324e5d6564c8554381019170839509bb


-- 
Yoann Congal
Smile ECS



  reply	other threads:[~2026-02-17  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16 16:45 [PATCH] busybox: Enable SELinux support if DISTRO_FEATURES contains 'selinux' "Uwe Kleine-König
2026-02-17  9:13 ` Yoann Congal [this message]
2026-02-17 16:25   ` [OE-core] " "Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGH4E8RFJGEA.R2SUJPB21TR0@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=joe.macdonald@siemens.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ukleinek@baylibre.com \
    --cc=yi.zhao@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox