Re: [OE-core] [PATCH 4/7] module.bbclass: move environment setup to kernel_module.py

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi,

On Mon Feb 23, 2026 at 10:06 PM CET, Adrian Freihofer via lists.openembedded.org wrote:
[...]
> diff --git a/meta/lib/oe/kernel_module.py b/meta/lib/oe/kernel_module.py
> new file mode 100644
> index 0000000000..678f7de03b
> --- /dev/null
> +++ b/meta/lib/oe/kernel_module.py
> @@ -0,0 +1,22 @@
> +
> +# Set up the environment for building kernel modules
> +def kernel_module_os_env(d, env_dict):
> +    env_dict['CFLAGS'] = ''
> +    env_dict['CPPFLAGS'] = ''
> +    env_dict['CXXFLAGS'] = ''
> +    env_dict['LDFLAGS'] = ''
> +
> +    env_dict['KERNEL_PATH'] = d.getVar('STAGING_KERNEL_DIR')
> +    env_dict['KERNEL_SRC'] = d.getVar('STAGING_KERNEL_DIR')
> +    env_dict['KERNEL_VERSION'] = d.getVar('KERNEL_VERSION')
> +    env_dict['CC'] = d.getVar('KERNEL_CC')
> +    env_dict['LD'] = d.getVar('KERNEL_LD')
> +    env_dict['AR'] = d.getVar('KERNEL_AR')
> +    env_dict['OBJCOPY'] = d.getVar('KERNEL_OBJCOPY')
> +    env_dict['STRIP'] = d.getVar('KERNEL_STRIP')
> +    env_dict['O'] = d.getVar('STAGING_KERNEL_BUILDDIR')
> +    kbuild_extra_symbols = d.getVar('KBUILD_EXTRA_SYMBOLS')
> +    if kbuild_extra_symbols:
> +        env_dict['KBUILD_EXTRA_SYMBOLS'] = kbuild_extra_symbols
> +    else:
> +        env_dict['KBUILD_EXTRA_SYMBOLS'] = ''

This is missing an SPDX identifier, which should be something like:

#
# Copyright OpenEmbedded Contributors
#
# SPDX-License-Identifier: GPL-2.0-only
#

from looking at the other files.

During the patch review call we said it was fine to merge without it for now but
could you follow-up with a patch adding it?

Thanks,
Antonin