From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <stondo@gmail.com>, <openembedded-core@lists.openembedded.org>
Cc: <Ross.Burton@arm.com>, <jpewhacker@gmail.com>,
<stefano.tondo.ext@siemens.com>, <Peter.Marko@siemens.com>,
<adrian.freihofer@siemens.com>
Subject: Re: [OE-core][PATCH v11 0/4] SPDX 3.0 SBOM enrichment and compliance improvements
Date: Sat, 21 Mar 2026 17:29:43 +0100 [thread overview]
Message-ID: <DH8LPQQUCZSI.7ERSNCGXCA51@bootlin.com> (raw)
In-Reply-To: <20260321131826.1401671-1-stondo@gmail.com>
On Sat Mar 21, 2026 at 2:18 PM CET, Stefano Tondo via lists.openembedded.org wrote:
> From: Stefano Tondo <stefano.tondo.ext@siemens.com>
>
> This series enhances SPDX 3.0 SBOM generation with enriched
> metadata and compliance-oriented controls for current master.
>
> Compared with v10, this series has been rebased on top of current
> master after Joshua's related changes landed upstream. The merged or
> superseded pieces have been dropped, leaving the four still-relevant
> patches below.
>
> Changes since v10:
>
> - Rebased onto current master.
> - Dropped patches now merged or superseded upstream.
> - Restored the current recipe/build SPDX task split after rebase.
> - Updated the remaining selftests to use the current builds/ output
> paths.
> - Revalidated the source-download enrichment tests requested by
> Richard Purdie and Mathieu Dubois-Briand.
>
> Validated with:
>
> oe-selftest -r \
> spdx.SPDX30Check.test_packageconfig_spdx \
> spdx.SPDX30Check.test_download_location_defensive_handling \
> spdx.SPDX30Check.test_version_extraction_patterns
>
> Stefano Tondo (4):
Hi Stefano,
Thanks for the new version.
I believe a call to collect_package_providers() was not modified to add
the second argument:
NOTE: recipe core-image-full-cmdline-1.0-r0: task do_create_rootfs_spdx: Started
ERROR: core-image-full-cmdline-1.0-r0 do_create_rootfs_spdx: Error executing a python function in exec_func_python() autogenerated:
The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>
0001:
*** 0002:do_create_rootfs_spdx(d)
...
File: '/srv/pokybuild/yocto-worker/musl-qemux86-64/build/layers/openembedded-core/meta/lib/oe/spdx30_tasks.py', lineno: 1300, function: collect_build_package_inputs
1296:
1297:def collect_build_package_inputs(d, objset, build, packages, files_by_hash=None):
1298: import oe.sbom30
1299:
*** 1300: providers = oe.spdx_common.collect_package_providers(d)
1301:
1302: build_deps = set()
1303: missing_providers = set()
1304:
Exception: TypeError: collect_package_providers() missing 1 required positional argument: 'direct_deps'
https://autobuilder.yoctoproject.org/valkyrie/#/builders/3/builds/3489
Also, we have a warning about tabs in cpan.bbclass:
WARNING: python should use 4 spaces indentation, but found tabs in cpan.bbclass, line 73
WARNING: python should use 4 spaces indentation, but found tabs in cpan.bbclass, line 74
WARNING: python should use 4 spaces indentation, but found tabs in cpan.bbclass, line 75
WARNING: python should use 4 spaces indentation, but found tabs in cpan.bbclass, line 76
WARNING: python should use 4 spaces indentation, but found tabs in cpan.bbclass, line 77
WARNING: python should use 4 spaces indentation, but found tabs in cpan.bbclass, line 78
(same log file)
This file already had mixed tabs and spaces, so I'm not sure why this is
different.
Can you have a look at it?
Thanks,
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-03-21 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 13:18 [OE-core][PATCH v11 0/4] SPDX 3.0 SBOM enrichment and compliance improvements stondo
2026-03-21 13:18 ` [OE-core][PATCH v11 1/4] spdx30: Add configurable file exclusion pattern support stondo
2026-03-21 13:18 ` [OE-core][PATCH v11 2/4] spdx30: Add supplier support for image and SDK SBOMs stondo
2026-03-21 13:18 ` [OE-core][PATCH v11 3/4] spdx30: Enrich source downloads with version and PURL stondo
2026-03-21 13:18 ` [OE-core][PATCH v11 4/4] oeqa/selftest: Add tests for source download enrichment stondo
2026-03-21 16:29 ` Mathieu Dubois-Briand [this message]
2026-03-23 13:03 ` [OE-core][PATCH v12 0/4] SPDX 3.0 SBOM enrichment and compliance improvements Stefano Tondo
2026-03-23 13:03 ` [PATCH v12 1/4] spdx30: Add configurable file exclusion pattern support Stefano Tondo
2026-03-23 13:03 ` [PATCH v12 2/4] spdx30: Add supplier support for image and SDK SBOMs Stefano Tondo
2026-03-23 13:03 ` [PATCH v12 3/4] spdx30: Enrich source downloads with version and PURL Stefano Tondo
2026-03-23 13:03 ` [PATCH v12 4/4] oeqa/selftest: Add tests for source download enrichment Stefano Tondo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH8LPQQUCZSI.7ERSNCGXCA51@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=Peter.Marko@siemens.com \
--cc=Ross.Burton@arm.com \
--cc=adrian.freihofer@siemens.com \
--cc=jpewhacker@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=stefano.tondo.ext@siemens.com \
--cc=stondo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox