Re: [OE-core] [scarthgap][PATCH 5/6] elfutils: don't add -Werror to avoid discarded-qualifiers

["Yoann Congal" <yoann.congal@smile.fr>]

On Thu Mar 26, 2026 at 7:14 PM CET, Martin Jansa via lists.openembedded.org wrote:
> From: Martin Jansa <martin.jansa@gmail.com>
>
> With glibc-2.43 on host elfutils-native fails with:
> elfutils-0.191/libcpu/riscv_disasm.c:1259:46: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>
> elfutils-0.194 in master doesn't have this issue thanks to this patch avoiding -Werror from:
> https://git.openembedded.org/openembedded-core/commit/?id=1d6ac3c811798732e6addc798656bbe104661d77
>
> Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> ---

Hello

Isn't this patch (and 6/6) also needed on whinlatter?
Can you send what is needed from series to whinlatter please?

Thanks!

>  .../elfutils/elfutils_0.191.bb                |  1 +
>  ...001-config-eu.am-do-not-force-Werror.patch | 34 +++++++++++++++++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 meta/recipes-devtools/elfutils/files/0001-config-eu.am-do-not-force-Werror.patch
>
> diff --git a/meta/recipes-devtools/elfutils/elfutils_0.191.bb b/meta/recipes-devtools/elfutils/elfutils_0.191.bb
> index 0fd6d31af1..5156e5c9f6 100644
> --- a/meta/recipes-devtools/elfutils/elfutils_0.191.bb
> +++ b/meta/recipes-devtools/elfutils/elfutils_0.191.bb
> @@ -23,6 +23,7 @@ SRC_URI = "https://sourceware.org/elfutils/ftp/${PV}/${BP}.tar.bz2 \
>             file://0001-tests-Makefile.am-compile-test_nlist-with-standard-C.patch \
>             file://0001-debuginfod-Remove-unused-variable.patch \
>             file://0001-srcfiles-fix-unused-variable-BUFFER_SIZE.patch \
> +           file://0001-config-eu.am-do-not-force-Werror.patch \
>             file://CVE-2025-1352.patch \
>             file://CVE-2025-1365.patch \
>             file://CVE-2025-1372.patch \
> diff --git a/meta/recipes-devtools/elfutils/files/0001-config-eu.am-do-not-force-Werror.patch b/meta/recipes-devtools/elfutils/files/0001-config-eu.am-do-not-force-Werror.patch
> new file mode 100644
> index 0000000000..d4e141927f
> --- /dev/null
> +++ b/meta/recipes-devtools/elfutils/files/0001-config-eu.am-do-not-force-Werror.patch
> @@ -0,0 +1,34 @@
> +From e169c3fc734be1783b3e1a4768dbec05fb64cb4f Mon Sep 17 00:00:00 2001
> +From: Alexander Kanavin <alex@linutronix.de>
> +Date: Fri, 22 Nov 2024 12:50:48 +0100
> +Subject: [PATCH] config/eu.am: do not force -Werror
> +
> +This is undesirable when compiler versions may not be the same
> +as what upstream is using for their own testing.
> +
> +Upstream-Status: Inappropriate [oe-core specific]
> +Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> +---
> + config/eu.am | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/config/eu.am b/config/eu.am
> +index 0b7dab5..5e7a03f 100644
> +--- a/config/eu.am
> ++++ b/config/eu.am
> +@@ -99,7 +99,6 @@ AM_CFLAGS = -std=gnu99 -Wall -Wshadow -Wformat=2 \
> + 	    $(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \
> + 	    $(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \
> + 	    $(USE_AFTER_FREE3_WARNING) \
> +-	    $(if $($(*F)_no_Werror),,-Werror) \
> + 	    $(if $($(*F)_no_Wunused),,-Wunused -Wextra) \
> + 	    $(if $($(*F)_no_Wstack_usage),,$(STACK_USAGE_WARNING)) \
> + 	    $(if $($(*F)_no_Wpacked_not_aligned),$(NO_PACKED_NOT_ALIGNED_WARNING),) \
> +@@ -109,7 +108,6 @@ AM_CXXFLAGS = -std=c++11 -Wall -Wshadow \
> + 	   $(TRAMPOLINES_WARNING) \
> + 	   $(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \
> + 	   $(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \
> +-	   $(if $($(*F)_no_Werror),,-Werror) \
> + 	   $(if $($(*F)_no_Wunused),,-Wunused -Wextra) \
> + 	   $(if $($(*F)_no_Wstack_usage),,$(STACK_USAGE_WARNING)) \
> + 	   $(if $($(*F)_no_Wpacked_not_aligned),$(NO_PACKED_NOT_ALIGNED_WARNING),) \


-- 
Yoann Congal
Smile ECS